ER: Proposed edits to Pull Request template

[t-will-gillis]

Emergent Requirement - Problem

Many of the same errors appear in PRs, and some of these errors might be adverted by making minor changes to the PR template. Please see below

Issue you discovered this emergent requirement in

• Added GitHub handle for Shawn Duenas #6916

Date discovered

6/2/24

Did you have to do something temporarily

• YES
• NO

Who was involved

@t-will-gillis

What happens if this is not addressed

We will continue to have errors needing to be addressed in PR reviews.

Resources

pull_request_template.md

Recommended Action Items

• Make a new issue
• Discuss with team
• Let a Team Lead know

Potential solutions [draft]

• To address a problem where devs do not link an issue to "Fixes: # ":
  • Add comment above "Fixes " line:
    <!-- Important! Add the number of the issue you worked on after Fixes # -->
  • We could also incorporate this workflow in the Lucky Parking project that posts a message if the dev doesn't link an issue. Probably would need to be integrated with set-pr-labels
• To address the case when devs forget to add spaces after the tics in the 'what did you do and why' sections, add single space after each tic mark so that dev is beginning with the space already
• Additionally, add a comment after the "What did you do.." and the "Why did you do it" that says:
  <!-- Note: add lines if needed, and remove any unused lines -->
• To address the case where devs fail to remove the code after "Screenshots.." , modify the notes to:

  <!-- Notes: 
  - If there are no visual change to the website, delete all of the script below and replace with "- No visual changes" or similar
  - If your images are too big, use the <img src="" width="" length="" />  syntax instead of ![image](link) to format the images
  - If images are not loading properly, you might need to double check the syntax or add a newline after the closing </summary> tag 
  -->  
  

Example of propsed PR Template

[github-actions]

Hi @t-will-gillis.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing:

• Complexity, Role, Feature

NOTE: Please ignore this comment if you do not have 'write' access to this directory.

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards.
To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.

Additional Resources:

• Wiki: How to create issues
• Wiki: How to read and interpret labels

[github-actions]

Hi @t-will-gillis, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)