Added GitHub handle for Shawn Duenas#6916
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
@cflemmonds Please complete this PR, following instructions in the CONTRIBUTING section 3. In particular, in the first line of the PR, please replace the string "replace_this_text_with_the_issue_number" with the issue number. As it is, we have no issue linked to this PR so we cannot review it. When that is done, please complete the other sections of the PR:
Thank you! |
@cflemmonds Once you completed the steps mentioned from @roslynwythe , please mention me in the comment so that I could go ahead and start the review process, thank you! Please feel free to reach out if you need any help along the process! |
|
Hi @ino-iosdev, I think you intended to add yourself as a reviewer instead of self-assigning as an Assignee. I've unassigned you and added you as a reviewer instead. Thanks! |
|
Hi @cflemmonds, please address the comments from @roslynwythe and @ino-iosdev. If you are unable to continue working on this issue, let us know and we'll unassign you. Thanks! |
github-actions
bot
added
good first issue
|
Thank you for all of your help! I have made the edits to the initial comment. If there is anything else I need to update, please let me know. Thanks again. |
There was a problem hiding this comment.
@cflemmonds thank you for the revision!
- Issue number was properly linked
- branch naming is good
Changes required:
-
Remove 6719 from the title (we don't need to add it there, note how it becomes unclear since it stacks with your PR number 6916)
-
Revise the actual change made in the file: DO NOT delete the original github link, the issue did NOT request you to add a link, it just needs you to add
github-handle:under- name: Shawn Duenas, please read the instruction again in the issue #6719 -
Use syntax highlight when referencing syntax so that it's clear to read, in the
What changes did you make?section, quote from the original issue change request when laying out the changes you made, this is good to double check whether you followed the exact change instruction. To make syntax highlight, add a backtick at the beginning and end of the words you wish to highlight. Then clickPreviewto check how it turns out when people read it, see below:
What you type in Write section
What you see in Preview section
- Revise the
Why did you make the changesanswer: In general, it's a good practice to write details in your own words based on the request from the issue, see below from the original issue page:
Check out this example of a similar issue for your reference #6917
After making all these changes, don't forget to click on something like this on the top right of your page (see below) to request a review of your changes:
t-will-gillis
left a comment
t-will-gillis
left a comment
There was a problem hiding this comment.
Hey @cflemmonds Good job so far with this issue, and thanks for working with everyone to address their comments.
- Regarding the issue title- I tend to leave the issue number in the title myself (I have an open PR right now where I do this). In other words, I am OK either with or without the issue number. Since this is not a stated requirement from Hack for LA, I am not going to ask you to make this change.
- Regarding the code edits: it seems there was some confusion with issues like this one.
- As @ino-iosdev referenced, line 27 was not part of the issue so please change this back to
github: 'https://github.com/McRawly'. - The intent of the issue is that a new line should be inserted after line 23
-name: Shawn Duenas. This new line should saygithub-handle:and be inline as shwon. - Note: the intended result is shown on Lines 10 and 17 of the same file.
- As @ino-iosdev referenced, line 27 was not part of the issue so please change this back to
- Regarding "What changes did you make..." and "Why...", as mentioned typically you will want to give a brief summary of the "Overview" of the original issue. For the "What.." section, you could say something to the effect of "Add a single variable
github-handleafter team member's name", and for "Why..", you could say something like "This variable will be used in the future to reduce redundancy in the project file."
Thanks for sticking with this- you are almost there!
One last note: @ino-iosdev please remember, these are 'requested changes', not 'required changes'.
|
I want to begin with thanking you both for your feedback and clarifying the issue. I have taken your feedback and made the necessary changes. If I missed anything, please to hesitate to remind me! |
There was a problem hiding this comment.
@cflemmonds Perfect- thanks for making the changes.
(Don't forget to click on the chasing arrows to re-request a review from @ino-iosdev )
Details
ino-iosdev
left a comment
ino-iosdev
left a comment
There was a problem hiding this comment.
@cflemmonds Thank you for all the update, great job!
Since there are a few of these PRs re adding github handle, to make the title visually clear, it would be good to add the name of the person, e.g. Added github-handle for Shawn Duenas, hope this makes sense to you. I'm good to approve after this last bit of change, thank you.
|
@ino-iosdev thanks so much for that suggestion, I've made the requested change to the title! Thanks again |
jphamtv
left a comment
jphamtv
left a comment
There was a problem hiding this comment.
Hey @cflemmonds, thanks for making the requested title change and addressing all the feedback. Great work!
jphamtv
dismissed
ino-iosdev’s stale review
Confirmed the requested title change was made
5 participants
Fixes #6719
What changes did you make?
github-handleafter team member's nameWhy did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Details
No visual changes to the website