Skip to content

Added Github-handle for Bryon Heart#6917

Merged
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
ino-iosdev:add-github-handle-for-bryon-heart-6730
Jun 2, 2024
Merged

Added Github-handle for Bryon Heart#6917
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
ino-iosdev:add-github-handle-for-bryon-heart-6730

Conversation

@ino-iosdev
Copy link
Member

@ino-iosdev ino-iosdev commented May 31, 2024

Fixes #6730

What changes did you make?

  • Added github-handle: for Bryon Heart

Why did you make the changes (we will use this info to test)?

  • Create a single variable github-handle for each member of the leadership team in order to reduce redundancy in the project file.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • No visual change on the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b ino-iosdev-add-github-handle-for-bryon-heart-6730 gh-pages
git pull https://github.com/ino-iosdev/website.git add-github-handle-for-bryon-heart-6730

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels May 31, 2024
Copy link
Member

@dcotelessa dcotelessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review ETA: 9PM 5/31/24

Looks good!

  • Branching done correctly with included ticket number
  • No visual changes. (Checked on localhost.)
  • Used spaces and correctly added the github-handle property
  • Proper naming of the issue

Thanks!

@iancooperman iancooperman self-requested a review June 1, 2024 23:17
@iancooperman
Copy link
Member

ETA: EoD

Copy link
Member

@iancooperman iancooperman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Branch named appropriately
  • No out-of-scope changes

Great job. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add github-handle for Bryon Heart in engage.md

4 participants