add github-handle variable for Gian Reyes Dionisio by williamzhang73 · Pull Request #6984 · hackforla/website

williamzhang73 · 2024-06-10T22:12:41Z

Fixes #6937

What changes did you make?

-add github-handle: for Gian Reyes Dionisio

Why did you make the changes (we will use this info to test)?

-add Github handle variable for Gian Reyes Dinnisio to reduce redundancy in the project file.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

-No visual change on the website.

github-actions · 2024-06-10T22:13:11Z

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b williamzhang73-add-github-handle-6937 gh-pages
git pull https://github.com/williamzhang73/website.git add-github-handle-6937

dcotelessa · 2024-06-11T04:51:00Z

Hi williamzhang,

Thanks for the PR. We need a few updates:

In the PR description, we need to replace "Fixes #replace_this_text_with_the_issue_number" with the number of the ticket, linking the task to the ticket. This is described here
Also, we can remove the "Screenshots" portion of the PR description as there are no visual changes.
The github-handle is applied and left blank , as the task is described.

Look forward to the update, thanks!

williamzhang73 · 2024-06-11T16:00:18Z

Thanks @dcotelessa,

The issue number was updated.
The "screenshots" part of the PR description was removed.
please review it again.

dcotelessa

Thanks for the updates.
The description looks good and the passing all tests.
Great job!

andyphancode · 2024-06-12T00:51:58Z

Review ETA: 6/11/2024 EOD
Availability: Throughout week

andyphancode

Looks good!

Correctly merging from collaborator's branch into hackforla:gh-pages
Issue is correctly fixed (github-handle: added)

Approved.

ino-iosdev

@williamzhang73

Issue number was properly linked
Branch naming is good (just a side note for future reference, no need to make change on this one: branch naming is more clear if you could include the name of the person, e.g. add-github-handle-for-bryon-heart-6730)

Changes required:

Remove 6937 from the title (notice how it becomes unclear since it stacks with your PR number)
Use syntax highlight when referencing changes made so that it's clear to read, e.g. below:

Revise the Why did you make the changes answer: In general, it's a good practice to write details in your own words based on the request from the issue, e.g. #6917
Please include this at the end if no visual change is made to the website:

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

-  No visual change on the website.

After making all these changes, don't forget to click on something like this on the top right of your page (see below) to request a review of your changes:

ino-iosdev · 2024-06-12T17:16:20Z

Looks good!

Correctly merging from collaborator's branch into hackforla:gh-pages

Issue is correctly fixed (github-handle: added)

Approved.

@andyphancode Just noticed that your view mentioned merging, since this is a pushing only, and the merge team will be handling merging once it's approved overall, I would kindly suggest to say correctly pushing instead to avoid confusing. Hope this make sense, cheers!

del9ra · 2024-06-14T00:31:59Z

ETA: 06/13/24
Availability: 1-5 PM monday-friday

del9ra

HI @williamzhang73 Well done! Good job!

The branching was done correctly
No need to mention issue number in the PR title. Refer to this guide https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md
Issue number was listed
Not all pull requests will have significant changes to our website. Please just add the following explanation for no images like:
### Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes to the website.
Please refer to the Contributing Guide: https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md
Changes were made correctly in the code
Please provide a more detailed explanation of why the changes are being made
Thank you! Just make these changes, and I'll be happy to approve it.

jphamtv · 2024-06-20T19:19:46Z

Hi @williamzhang73 - Please update the "What changes did you make?" summary according to @ino-iosdev's feedback:

Use syntax highlight when referencing changes made so that it's clear to read, e.g. below:

Tip: Remove the underscores (_), and use backticks (`) instead

Once updated, ping @ino-iosdev to review and approve the changes. This PR is ready to be merged and is only waiting for this final update. Thanks!

The requested changes have been made

ino-iosdev

Thank you for the changes!

…ackforla#6984)

) * updated-team-meeting-data-6920 * Update contributor and language data * Update contributor and language data * Fix Capitalization of "Slack" in CONTRIBUTING.MD - line 582 (#7038) * Update contributor and language data * Modified spell-check-audit.md file, changed label Feature: Administrative to feature: spelling (#7036) * PBB migration "Issue Trigger" (#7053) * Update issue-trigger.yml Changes in prep for Projects Beta migration * Update issue-trigger.yml space added to comment * Update issue-trigger.yml edits to comment at Team Members * Update preliminary-update-comment.js refactoring for PBB migration * PBB migration "Pull Request Trigger" (#7054) * Update pull-request-trigger.yml edits for PBB migration * Update pull-request-trigger.yml remove test branch * PBB migration "Schedule Friday" (#7055) * Update schedule-fri-0700.yml Changes for PBB migration * Update add-label.js * Update find-linked-issue.js For PBB migration * Update add-label.js remove refs to personal repo * Update add-label.js addressing CodeQL alert * Update add-label.js address CodeQL alert * PBB migration "Move Closed Issues" (#7056) * Update move-closed-issues.yaml for migration to PBB * Update sort-closed-issues.js * Add github-handle for Roland Abregorivas in heart.md #6940 (#7009) * github-handle variable added for Gian Reyes Dionisio #6937 (#6984) * Update contributor and language data * updated role for Will Gillis on website project profile (#7063) * Add github handle for Marie (#7059) * added github handle element for Tien Yuan in heart.md (#7069) * Update contributor and language data * Fixes #7046 Added github handle to _projects/heart.md for Jason LaManque. * Update Roslyn's role to Developer Co-Lead (#7070) * img Tag Refactor in Contributing.md page (#7068) * Update contributor and language data * Added github-handle to Adrian Inchauste's section (#7074) * Update contributor and language data * edited Samantha Hyler to be Co-lead AND added Emma Thrash (#7040) * 6786 remove bop from untaggedrepoids in get project datajs (#7062) * remove references to BoP's id from the `untaggedRepoIds` list * Update contributor and language data * Revert `github.repository` post GHA test * Resolve merge conflicts * Resolve merge conflicts (p2) --------- Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org> * Update CONTRIBUTING.md Section 2.7.d with correct stream branch (#7082) * Update meeting data * Update contributor and language data * Update Inactive Members JSON * Revert "updated-team-meeting-data-6920 (#7043)" (#7086) This reverts commit dc11c65. * Update contributor and language data * Update contributor and language data * updated team meeting data on events page to show meeting frequency * Add 'Leadership Option' to Issue Template for CoP Information Update (#7077) * add leadership type option with dropdown fields * remove whitespace between labels and body * remove whitespace in title * remove whitespace in front of the yes/no options * change default type * Update contributor and language data * Updated spell checker to ignore memebers names (#7073) * Update contributor and language data * Update contributor and language data * truncate contributors name in filter tag with ellipis (#7052) * Update contributor and language data --------- Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org> Co-authored-by: David Cotelessa <david@cotelessa.com> Co-authored-by: Santiago Secco <53095957+santisecco@users.noreply.github.com> Co-authored-by: Will Gillis <40799239+t-will-gillis@users.noreply.github.com> Co-authored-by: Jennifer Sung <72041281+jennisung@users.noreply.github.com> Co-authored-by: williamzhang <willzhang73@gmail.com> Co-authored-by: Melissa McGrath <157540251+melissam640@users.noreply.github.com> Co-authored-by: Austin Labador <67137399+alabador@users.noreply.github.com> Co-authored-by: Matthew McCane <78394982+DakuwoN@users.noreply.github.com> Co-authored-by: Kim <109393217+Kle012@users.noreply.github.com> Co-authored-by: Christopher Chang <64837366+cchrizzle@users.noreply.github.com> Co-authored-by: duojet2ez <epstringskip@gmail.com> Co-authored-by: Mateo Rodriguez <79176075+mrodz@users.noreply.github.com> Co-authored-by: Danielle Andrews <62191468+DrAcula27@users.noreply.github.com> Co-authored-by: vanessasinam <85697744+vanessasinam@users.noreply.github.com> Co-authored-by: Aadil Ahmed <aadilahmed0@gmail.com>

github-handle variable added for Gian Reyes Dionisio hackforla#6937

0903f52

dcotelessa approved these changes Jun 11, 2024

View reviewed changes

dcotelessa mentioned this pull request Jun 11, 2024

Fixes Add github-handle for Adrian Inchauste in heart.md #6934 #6982

Closed

andyphancode self-requested a review June 12, 2024 00:50

andyphancode approved these changes Jun 12, 2024

View reviewed changes

ino-iosdev self-requested a review June 12, 2024 01:18

ino-iosdev previously requested changes Jun 12, 2024

View reviewed changes

ino-iosdev mentioned this pull request Jun 12, 2024

ER: update the pull request contributing guidelines #6990

Closed

5 tasks

del9ra self-requested a review June 14, 2024 00:31

del9ra suggested changes Jun 14, 2024

View reviewed changes

williamzhang73 changed the title ~~github-handle variable added for Gian Reyes Dionisio #6937~~ add github-handle variable for Gian Reyes Dionisio Jun 16, 2024

ExperimentsInHonesty added role: back end and removed role: back end/devOps Tasks for back-end developers labels Jun 18, 2024

github-actions bot added the role: back end/devOps Tasks for back-end developers label Jun 18, 2024

williamzhang73 removed the role: back end/devOps Tasks for back-end developers label Jun 18, 2024

github-actions bot added the role: back end/devOps Tasks for back-end developers label Jun 18, 2024

williamzhang73 requested review from del9ra and ino-iosdev June 18, 2024 18:04

del9ra approved these changes Jun 18, 2024

View reviewed changes

t-will-gillis merged commit c41c80c into hackforla:gh-pages Jun 23, 2024

ino-iosdev reviewed Jun 24, 2024

View reviewed changes

terrencejihoonjung pushed a commit to terrencejihoonjung/website that referenced this pull request Jul 5, 2024

github-handle variable added for Gian Reyes Dionisio hackforla#6937 (h…

a151951

…ackforla#6984)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add github-handle variable for Gian Reyes Dionisio#6984

add github-handle variable for Gian Reyes Dionisio#6984
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
williamzhang73:add-github-handle-6937

williamzhang73 commented Jun 10, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jun 10, 2024

Uh oh!

dcotelessa commented Jun 11, 2024

Uh oh!

williamzhang73 commented Jun 11, 2024 •

edited

Loading

Uh oh!

dcotelessa left a comment

Uh oh!

andyphancode commented Jun 12, 2024

Uh oh!

andyphancode left a comment

Uh oh!

ino-iosdev left a comment

Uh oh!

ino-iosdev commented Jun 12, 2024

Uh oh!

del9ra commented Jun 14, 2024

Uh oh!

del9ra left a comment

Uh oh!

jphamtv commented Jun 20, 2024

Uh oh!

ino-iosdev left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

williamzhang73 commented Jun 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes did you make?

Why did you make the changes (we will use this info to test)?

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Uh oh!

github-actions bot commented Jun 10, 2024

Uh oh!

dcotelessa commented Jun 11, 2024

Uh oh!

williamzhang73 commented Jun 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dcotelessa left a comment

Choose a reason for hiding this comment

Uh oh!

andyphancode commented Jun 12, 2024

Uh oh!

andyphancode left a comment

Choose a reason for hiding this comment

Uh oh!

ino-iosdev left a comment

Choose a reason for hiding this comment

Changes required:

Uh oh!

ino-iosdev commented Jun 12, 2024

Uh oh!

del9ra commented Jun 14, 2024

Uh oh!

del9ra left a comment

Choose a reason for hiding this comment

Uh oh!

jphamtv commented Jun 20, 2024

Uh oh!

ino-iosdev left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

williamzhang73 commented Jun 10, 2024 •

edited

Loading

williamzhang73 commented Jun 11, 2024 •

edited

Loading