Skip to content

Update-project-profile-expunge-assist #6986#7040

Merged
drakenguyen4000 merged 1 commit intohackforla:gh-pagesfrom
duojet2ez:update-project-profile-expunge-assist-edit-samanthaHyler-role-6986
Jun 30, 2024
Merged

Update-project-profile-expunge-assist #6986#7040
drakenguyen4000 merged 1 commit intohackforla:gh-pagesfrom
duojet2ez:update-project-profile-expunge-assist-edit-samanthaHyler-role-6986

Conversation

@duojet2ez
Copy link
Member

Fixes #6986

What changes did you make?

  • In _projects/expunge-assist.md I edited Samantha Hyler's role to 'Team-Co-lead'
  • In _projects/expunge-assist.md I added Emma Thrash as a Co-lead after the other Co-leads and included all profile info

Why did you make the changes (we will use this info to test)?

  • I made these changes to update the expunge-assist page with the current information

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

6986_before

Visuals after changes are applied

6986_after

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b duojet2ez-update-project-profile-expunge-assist-edit-samanthaHyler-role-6986 gh-pages
git pull https://github.com/duojet2ez/website.git update-project-profile-expunge-assist-edit-samanthaHyler-role-6986

@github-actions github-actions bot added role: front end Tasks for front end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jun 20, 2024
@ramitaarora ramitaarora self-requested a review June 22, 2024 00:09
@ramitaarora
Copy link
Member

ETA: Mon June 24 EoD
Availability: Weekday mornings

@terrencejihoonjung terrencejihoonjung self-requested a review June 23, 2024 01:55
@terrencejihoonjung
Copy link
Member

ETA: 06/25/24, 11:59pm
Availability: weekday evenings

Copy link
Member

@ramitaarora ramitaarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

  • You changed the correct profile role
  • You correctly added the new profile information
  • The new information is rendering on your branch

Great job! Thank you for contributing :)

@LRenDO
Copy link
Member

LRenDO commented Jun 26, 2024

Hi @terrencejihoonjung! Thanks for volunteering to review this issue! When you have a minute, please update your ETA and Availability. If for some reason you find that you're no longer able to review the request, please remove yourself as a reviewer. Thanks!

@terrencejihoonjung
Copy link
Member

Updated ETA: 06/27/24, 11:59pm
Updated Availability: weekday evenings

Copy link
Member

@terrencejihoonjung terrencejihoonjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @duojet2ez!

  • changes made and why they were made are clearly stated
  • branching is correct
  • correctly modified role and added profile information for "Emma Thrash"
  • visual changes are shown

Great job! Thank you!

@drakenguyen4000 drakenguyen4000 merged commit f7d8b24 into hackforla:gh-pages Jun 30, 2024
terrencejihoonjung pushed a commit to terrencejihoonjung/website that referenced this pull request Jul 5, 2024
t-will-gillis added a commit that referenced this pull request Aug 18, 2024
)

* updated-team-meeting-data-6920

* Update contributor and language data

* Update contributor and language data

* Fix Capitalization of "Slack" in CONTRIBUTING.MD - line 582 (#7038)

* Update contributor and language data

* Modified spell-check-audit.md file, changed label Feature: Administrative to feature: spelling (#7036)

* PBB migration "Issue Trigger"  (#7053)

* Update issue-trigger.yml

Changes in prep for Projects Beta migration

* Update issue-trigger.yml

space added to comment

* Update issue-trigger.yml

edits to comment at Team Members

* Update preliminary-update-comment.js

refactoring for PBB migration

* PBB migration "Pull Request Trigger" (#7054)

* Update pull-request-trigger.yml

edits for PBB migration

* Update pull-request-trigger.yml

remove test branch

* PBB migration "Schedule Friday" (#7055)

* Update schedule-fri-0700.yml

Changes for PBB migration

* Update add-label.js

* Update find-linked-issue.js

For PBB migration

* Update add-label.js

remove refs to personal repo

* Update add-label.js

addressing CodeQL alert

* Update add-label.js

address CodeQL alert

* PBB migration "Move Closed Issues" (#7056)

* Update move-closed-issues.yaml

for migration to PBB

* Update sort-closed-issues.js

* Add github-handle for Roland Abregorivas in heart.md #6940 (#7009)

* github-handle variable added for Gian Reyes Dionisio #6937 (#6984)

* Update contributor and language data

* updated role for Will Gillis on website project profile (#7063)

* Add github handle for Marie (#7059)

* added github handle element for Tien Yuan in heart.md (#7069)

* Update contributor and language data

* Fixes #7046 Added github handle to _projects/heart.md for Jason LaManque.

* Update Roslyn's role to Developer Co-Lead (#7070)

* img Tag Refactor in Contributing.md page  (#7068)

* Update contributor and language data

* Added github-handle to Adrian Inchauste's section (#7074)

* Update contributor and language data

* edited Samantha Hyler to be Co-lead AND added Emma Thrash (#7040)

* 6786 remove bop from untaggedrepoids in get project datajs (#7062)

* remove references to BoP's id from the `untaggedRepoIds` list

* Update contributor and language data

* Revert `github.repository` post GHA test

* Resolve merge conflicts

* Resolve merge conflicts (p2)

---------

Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org>

* Update CONTRIBUTING.md Section 2.7.d with correct stream branch (#7082)

* Update meeting data

* Update contributor and language data

* Update Inactive Members JSON

* Revert "updated-team-meeting-data-6920 (#7043)" (#7086)

This reverts commit dc11c65.

* Update contributor and language data

* Update contributor and language data

* updated team meeting data on events page to show meeting frequency

* Add 'Leadership Option' to Issue Template for CoP Information Update (#7077)

* add leadership type option with dropdown fields

* remove whitespace between labels and body

* remove whitespace in title

* remove whitespace in front of the yes/no options

* change default type

* Update contributor and language data

* Updated spell checker to ignore memebers names (#7073)

* Update contributor and language data

* Update contributor and language data

* truncate contributors name in filter tag with ellipis (#7052)

* Update contributor and language data

---------

Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org>
Co-authored-by: David Cotelessa <david@cotelessa.com>
Co-authored-by: Santiago Secco <53095957+santisecco@users.noreply.github.com>
Co-authored-by: Will Gillis <40799239+t-will-gillis@users.noreply.github.com>
Co-authored-by: Jennifer Sung <72041281+jennisung@users.noreply.github.com>
Co-authored-by: williamzhang <willzhang73@gmail.com>
Co-authored-by: Melissa McGrath <157540251+melissam640@users.noreply.github.com>
Co-authored-by: Austin Labador <67137399+alabador@users.noreply.github.com>
Co-authored-by: Matthew McCane <78394982+DakuwoN@users.noreply.github.com>
Co-authored-by: Kim <109393217+Kle012@users.noreply.github.com>
Co-authored-by: Christopher Chang <64837366+cchrizzle@users.noreply.github.com>
Co-authored-by: duojet2ez <epstringskip@gmail.com>
Co-authored-by: Mateo Rodriguez <79176075+mrodz@users.noreply.github.com>
Co-authored-by: Danielle Andrews <62191468+DrAcula27@users.noreply.github.com>
Co-authored-by: vanessasinam <85697744+vanessasinam@users.noreply.github.com>
Co-authored-by: Aadil Ahmed <aadilahmed0@gmail.com>
@duojet2ez duojet2ez deleted the update-project-profile-expunge-assist-edit-samanthaHyler-role-6986 branch September 12, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Expunge Assist (Add Emma Thrash, Update Samantha Hyler's Role)

5 participants