Add GitHub handle roland 6940#7009
Merged
t-will-gillis merged 2 commits intohackforla:gh-pagesfrom Jun 23, 2024
Merged
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
Member
|
Hi @jennisung Please add a comment to your previous PR that says that it is being replaced by this PR (include the #7009) and then close the previous PR- Thanks! |
Member
|
Review ETA: 1 pm 6/17/24 |
daras-cu
requested changes
Jun 17, 2024
Member
daras-cu
left a comment
daras-cu
left a comment
There was a problem hiding this comment.
Hi @jennisung, nice job with the changes! There are just a couple small things I think you need to change in the pull request, see below.
Correctly done:
- Pull request was done with the correct branch
- Understood and described the reason for the changes
- File was changed correctly and website was not visually affected
Need to fix:
- Link the pull request to the issue number (in the first line of the pull request, put the issue number where "replace_this_text_with_the_issue_number" is currently)
- In the screenshot section, you can get rid of the before and after image sections and just note that there were no visual changes to the site
Contributor
|
Hello @jennisung . So, the issue you having is same as the issue I Had. on the pull request form where it says Fixes, replace what you have with -> " Fixes #6940 ". The reason so the issue number serves as a direct link to the issue for other developers to look at. Also, certain task does not require screenshots. So, you can just say, No visual needed. |
mSharifHub
previously requested changes
Jun 17, 2024
Contributor
mSharifHub
left a comment
mSharifHub
left a comment
There was a problem hiding this comment.
Refer to the comment I left in conversations for the Request Change
github-actions
bot
added
good first issue
Closed
Member
Author
|
Thank you for the suggestions! I close the previous pull request #7008 and made the comment after closing it. And updated the description for this pull request. All checks have passed. |
ExperimentsInHonesty
added
role: back end
and removed
role: back end/devOps
daras-cu
approved these changes
Jun 18, 2024
Member
daras-cu
left a comment
daras-cu
left a comment
There was a problem hiding this comment.
Your updates look good, well done!
Member
|
Review ETA: 1 PM 6/20/2024 |
zkamenov
approved these changes
Jun 20, 2024
Member
zkamenov
left a comment
zkamenov
left a comment
There was a problem hiding this comment.
This change in the file is relevant, accurate, and robust. Keep up the good work!
t-will-gillis
dismissed
mSharifHub’s stale review
The dev is linking the previous issue with Fixes #6940
terrencejihoonjung
pushed a commit
to terrencejihoonjung/website
that referenced
this pull request
Jul 5, 2024
ExperimentsInHonesty
added
the
role: back end/devOps
31 tasks
t-will-gillis
added a commit
that referenced
this pull request
Aug 18, 2024
) * updated-team-meeting-data-6920 * Update contributor and language data * Update contributor and language data * Fix Capitalization of "Slack" in CONTRIBUTING.MD - line 582 (#7038) * Update contributor and language data * Modified spell-check-audit.md file, changed label Feature: Administrative to feature: spelling (#7036) * PBB migration "Issue Trigger" (#7053) * Update issue-trigger.yml Changes in prep for Projects Beta migration * Update issue-trigger.yml space added to comment * Update issue-trigger.yml edits to comment at Team Members * Update preliminary-update-comment.js refactoring for PBB migration * PBB migration "Pull Request Trigger" (#7054) * Update pull-request-trigger.yml edits for PBB migration * Update pull-request-trigger.yml remove test branch * PBB migration "Schedule Friday" (#7055) * Update schedule-fri-0700.yml Changes for PBB migration * Update add-label.js * Update find-linked-issue.js For PBB migration * Update add-label.js remove refs to personal repo * Update add-label.js addressing CodeQL alert * Update add-label.js address CodeQL alert * PBB migration "Move Closed Issues" (#7056) * Update move-closed-issues.yaml for migration to PBB * Update sort-closed-issues.js * Add github-handle for Roland Abregorivas in heart.md #6940 (#7009) * github-handle variable added for Gian Reyes Dionisio #6937 (#6984) * Update contributor and language data * updated role for Will Gillis on website project profile (#7063) * Add github handle for Marie (#7059) * added github handle element for Tien Yuan in heart.md (#7069) * Update contributor and language data * Fixes #7046 Added github handle to _projects/heart.md for Jason LaManque. * Update Roslyn's role to Developer Co-Lead (#7070) * img Tag Refactor in Contributing.md page (#7068) * Update contributor and language data * Added github-handle to Adrian Inchauste's section (#7074) * Update contributor and language data * edited Samantha Hyler to be Co-lead AND added Emma Thrash (#7040) * 6786 remove bop from untaggedrepoids in get project datajs (#7062) * remove references to BoP's id from the `untaggedRepoIds` list * Update contributor and language data * Revert `github.repository` post GHA test * Resolve merge conflicts * Resolve merge conflicts (p2) --------- Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org> * Update CONTRIBUTING.md Section 2.7.d with correct stream branch (#7082) * Update meeting data * Update contributor and language data * Update Inactive Members JSON * Revert "updated-team-meeting-data-6920 (#7043)" (#7086) This reverts commit dc11c65. * Update contributor and language data * Update contributor and language data * updated team meeting data on events page to show meeting frequency * Add 'Leadership Option' to Issue Template for CoP Information Update (#7077) * add leadership type option with dropdown fields * remove whitespace between labels and body * remove whitespace in title * remove whitespace in front of the yes/no options * change default type * Update contributor and language data * Updated spell checker to ignore memebers names (#7073) * Update contributor and language data * Update contributor and language data * truncate contributors name in filter tag with ellipis (#7052) * Update contributor and language data --------- Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org> Co-authored-by: David Cotelessa <david@cotelessa.com> Co-authored-by: Santiago Secco <53095957+santisecco@users.noreply.github.com> Co-authored-by: Will Gillis <40799239+t-will-gillis@users.noreply.github.com> Co-authored-by: Jennifer Sung <72041281+jennisung@users.noreply.github.com> Co-authored-by: williamzhang <willzhang73@gmail.com> Co-authored-by: Melissa McGrath <157540251+melissam640@users.noreply.github.com> Co-authored-by: Austin Labador <67137399+alabador@users.noreply.github.com> Co-authored-by: Matthew McCane <78394982+DakuwoN@users.noreply.github.com> Co-authored-by: Kim <109393217+Kle012@users.noreply.github.com> Co-authored-by: Christopher Chang <64837366+cchrizzle@users.noreply.github.com> Co-authored-by: duojet2ez <epstringskip@gmail.com> Co-authored-by: Mateo Rodriguez <79176075+mrodz@users.noreply.github.com> Co-authored-by: Danielle Andrews <62191468+DrAcula27@users.noreply.github.com> Co-authored-by: vanessasinam <85697744+vanessasinam@users.noreply.github.com> Co-authored-by: Aadil Ahmed <aadilahmed0@gmail.com>
This was referenced Aug 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6940
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes to the site.
No visual changes to the site.