Skip to content

Add github-handle for Roland Abregorivas in Heart Project#7071

Closed
izma-mujeeb wants to merge 2 commits intohackforla:gh-pagesfrom
izma-mujeeb:add-github-handle-7047
Closed

Add github-handle for Roland Abregorivas in Heart Project#7071
izma-mujeeb wants to merge 2 commits intohackforla:gh-pagesfrom
izma-mujeeb:add-github-handle-7047

Conversation

@izma-mujeeb
Copy link
Member

@izma-mujeeb izma-mujeeb commented Jun 27, 2024

Fixes #7047

What changes did you make?

  • Added github-handle for Roland Abregorivas in Heart Project

Why did you make the changes (we will use this info to test)?

  • I made this change to create a single variable that will replace the github and picture variables in the heart.md file

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

I only added a new variable and hence there are no visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b izma-mujeeb-add-github-handle-7047 gh-pages
git pull https://github.com/izma-mujeeb/website.git add-github-handle-7047

@izma-mujeeb izma-mujeeb added the good first issue Good for newcomers label Jun 27, 2024
@izma-mujeeb izma-mujeeb reopened this Jun 27, 2024
@jphamtv
Copy link
Member

jphamtv commented Jun 27, 2024

Hi @izma-mujeeb,

It appears there are no code changes to address the issue. Please ensure you've committed the necessary changes to resolve the problem described in the issue.

Additional items to update on this pull request before it's ready for review:

  1. In your summary, add a "#" before the issue number so it links the issue to this pull request.
  2. Manually add all the labels from the issue to this pull request. The labels didn't transfer over because the issue wasn't properly linked.

Thanks!

@izma-mujeeb izma-mujeeb added the role: front end Tasks for front end developers label Jun 27, 2024
@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jun 27, 2024
@izma-mujeeb izma-mujeeb added P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) and removed P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) labels Jun 27, 2024
@izma-mujeeb
Copy link
Member Author

Hi @jphamtv, thank you for your help!

As I was working on this issue on my local machine, I saw that the changes had already been made for this issue, hence there is no committed changes to be added. I am now wondering if there were two issues for this change and the pull request for the other issue has already been merged?

I have added all other items (labels, adding '#') to this pull request.

@jphamtv
Copy link
Member

jphamtv commented Jun 27, 2024

Hi @jphamtv, thank you for your help!

As I was working on this issue on my local machine, I saw that the changes had already been made for this issue, hence there is no committed changes to be added. I am now wondering if there were two issues for this change and the pull request for the other issue has already been merged?

I have added all other items (labels, adding '#') to this pull request.

@izma-mujeeb You're correct; that's exactly what happened. Thanks for pointing that out. I'm going to close this PR and the issue. Please pick up another good first issue from the Prioritized backlog column.

Closing this PR because the issue is fixed by #7009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Roland Abregorivas in heart.md

2 participants