6786 remove bop from untaggedrepoids in get project datajs#7062
Merged
t-will-gillis merged 5 commits intohackforla:gh-pagesfrom Jun 30, 2024
Conversation
mrodz
added
role: back end/devOps
roslynwythe
previously approved these changes
Jun 27, 2024
Member
There was a problem hiding this comment.
Great job @mrodz on this PR
- Code change is correct and clean
- PR is well-formed and descriptive
I tested the PR by pushing the branch to my fork of the repo, then triggering schedule-daily-1100.yml manually, then comparing the resulting github-data.json file against the original.
Member
|
@mrodz Please resolve the merge conflict. One method would be to overwrite |
Member
Author
Okay, will do! ETA: EOD 6/27 |
mrodz
force-pushed
the
6786-remove-bop-from-untaggedrepoids-in-get-project-datajs
branch
from
98a7d4b to
d876d52
Compare
Member
Author
|
This branch is up to date (by 3fb3698) with the latest |
t-will-gillis
approved these changes
Jun 30, 2024
Member
t-will-gillis
left a comment
t-will-gillis
left a comment
There was a problem hiding this comment.
Hey @mrodz Code Looks great- edits are clean for removing Brigade Playbook. Tested in my repo and it appears that the "Schedule Daily 1100" workflow is running as anticipated.
Thanks for fixing the Merge Conflict, and thanks for working on this issue
terrencejihoonjung
pushed a commit
to terrencejihoonjung/website
that referenced
this pull request
Jul 5, 2024
…#7062) * remove references to BoP's id from the `untaggedRepoIds` list * Update contributor and language data * Revert `github.repository` post GHA test * Resolve merge conflicts * Resolve merge conflicts (p2) --------- Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org>
mrodz
deleted the
6786-remove-bop-from-untaggedrepoids-in-get-project-datajs
branch
t-will-gillis
added a commit
that referenced
this pull request
Aug 18, 2024
) * updated-team-meeting-data-6920 * Update contributor and language data * Update contributor and language data * Fix Capitalization of "Slack" in CONTRIBUTING.MD - line 582 (#7038) * Update contributor and language data * Modified spell-check-audit.md file, changed label Feature: Administrative to feature: spelling (#7036) * PBB migration "Issue Trigger" (#7053) * Update issue-trigger.yml Changes in prep for Projects Beta migration * Update issue-trigger.yml space added to comment * Update issue-trigger.yml edits to comment at Team Members * Update preliminary-update-comment.js refactoring for PBB migration * PBB migration "Pull Request Trigger" (#7054) * Update pull-request-trigger.yml edits for PBB migration * Update pull-request-trigger.yml remove test branch * PBB migration "Schedule Friday" (#7055) * Update schedule-fri-0700.yml Changes for PBB migration * Update add-label.js * Update find-linked-issue.js For PBB migration * Update add-label.js remove refs to personal repo * Update add-label.js addressing CodeQL alert * Update add-label.js address CodeQL alert * PBB migration "Move Closed Issues" (#7056) * Update move-closed-issues.yaml for migration to PBB * Update sort-closed-issues.js * Add github-handle for Roland Abregorivas in heart.md #6940 (#7009) * github-handle variable added for Gian Reyes Dionisio #6937 (#6984) * Update contributor and language data * updated role for Will Gillis on website project profile (#7063) * Add github handle for Marie (#7059) * added github handle element for Tien Yuan in heart.md (#7069) * Update contributor and language data * Fixes #7046 Added github handle to _projects/heart.md for Jason LaManque. * Update Roslyn's role to Developer Co-Lead (#7070) * img Tag Refactor in Contributing.md page (#7068) * Update contributor and language data * Added github-handle to Adrian Inchauste's section (#7074) * Update contributor and language data * edited Samantha Hyler to be Co-lead AND added Emma Thrash (#7040) * 6786 remove bop from untaggedrepoids in get project datajs (#7062) * remove references to BoP's id from the `untaggedRepoIds` list * Update contributor and language data * Revert `github.repository` post GHA test * Resolve merge conflicts * Resolve merge conflicts (p2) --------- Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org> * Update CONTRIBUTING.md Section 2.7.d with correct stream branch (#7082) * Update meeting data * Update contributor and language data * Update Inactive Members JSON * Revert "updated-team-meeting-data-6920 (#7043)" (#7086) This reverts commit dc11c65. * Update contributor and language data * Update contributor and language data * updated team meeting data on events page to show meeting frequency * Add 'Leadership Option' to Issue Template for CoP Information Update (#7077) * add leadership type option with dropdown fields * remove whitespace between labels and body * remove whitespace in title * remove whitespace in front of the yes/no options * change default type * Update contributor and language data * Updated spell checker to ignore memebers names (#7073) * Update contributor and language data * Update contributor and language data * truncate contributors name in filter tag with ellipis (#7052) * Update contributor and language data --------- Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org> Co-authored-by: David Cotelessa <david@cotelessa.com> Co-authored-by: Santiago Secco <53095957+santisecco@users.noreply.github.com> Co-authored-by: Will Gillis <40799239+t-will-gillis@users.noreply.github.com> Co-authored-by: Jennifer Sung <72041281+jennisung@users.noreply.github.com> Co-authored-by: williamzhang <willzhang73@gmail.com> Co-authored-by: Melissa McGrath <157540251+melissam640@users.noreply.github.com> Co-authored-by: Austin Labador <67137399+alabador@users.noreply.github.com> Co-authored-by: Matthew McCane <78394982+DakuwoN@users.noreply.github.com> Co-authored-by: Kim <109393217+Kle012@users.noreply.github.com> Co-authored-by: Christopher Chang <64837366+cchrizzle@users.noreply.github.com> Co-authored-by: duojet2ez <epstringskip@gmail.com> Co-authored-by: Mateo Rodriguez <79176075+mrodz@users.noreply.github.com> Co-authored-by: Danielle Andrews <62191468+DrAcula27@users.noreply.github.com> Co-authored-by: vanessasinam <85697744+vanessasinam@users.noreply.github.com> Co-authored-by: Aadil Ahmed <aadilahmed0@gmail.com>
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6786
What changes did you make?
277577906) from the list of untaggedRepoIds and a commentschedule-daily-1100.ymlto test that BoP was still being properly fetchedWhy did you make the changes (we will use this info to test)?
hack-for-launder Code for America, but now it is controlled by Civic Tech Index and does have the tag. Thus, labeling it as untagged meant BoP data was being included twice.Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes to the website.
Note:
See f7709ea to confirm that "BoP" indeed is fetched using the new GHA.
Permalink to data post-update: here.