Skip to content

Added GitHub Handle Element for Tien Yuan in Heart Project#7069

Merged
LRenDO merged 1 commit intohackforla:gh-pagesfrom
melissam640:add-github-handle-element-6941
Jun 26, 2024
Merged

Added GitHub Handle Element for Tien Yuan in Heart Project#7069
LRenDO merged 1 commit intohackforla:gh-pagesfrom
melissam640:add-github-handle-element-6941

Conversation

@melissam640
Copy link
Member

@melissam640 melissam640 commented Jun 26, 2024

Fixes #6941

What changes did you make?

  • added variable github-handle for Tien Yuan in heart

Why did you make the changes (we will use this info to test)?

  • to create a single variable that will eventually replace the github and picture variables in the heart.md file

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Added a new variable. No visual changes to the website.

@github-actions
Copy link

github-actions bot commented Jun 26, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b melissam640-add-github-handle-element-6941 gh-pages
git pull https://github.com/melissam640/website.git add-github-handle-element-6941

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours role: back end labels Jun 26, 2024
@Anahisv23 Anahisv23 self-requested a review June 26, 2024 21:53
@Anahisv23
Copy link
Member

Anahisv23 commented Jun 26, 2024

ETA: EOD
Availability: 11am - 5pm M - F

Anahisv23
Anahisv23 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@Anahisv23 Anahisv23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @melissam640 thanks for working on this issue! Everything looks good on my end. Overall nice work!

Here's what you did well

  • Into and from branch are correct
  • Linked Issue is correct
  • Appropriate files were changed and appropriate changes were made

@LRenDO LRenDO self-requested a review June 26, 2024 23:31
LRenDO
LRenDO approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@LRenDO LRenDO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @melissam640! This looks great!

  • The branching was done correctly
  • Issue number was listed
  • The PR title is descriptive of the changes
  • Changes were made correctly in the code
  • Changes do not impact the site
  • A note was included that there were no visual changes
  • The PR request clearly states what was updated
  • The PR request states why the changes are being made

Thanks for contributing!

@LRenDO LRenDO merged commit bda92af into hackforla:gh-pages Jun 26, 2024
This was referenced Jun 26, 2024
Closed
Closed
terrencejihoonjung pushed a commit to terrencejihoonjung/website that referenced this pull request Jul 5, 2024
@melissam640 @terrencejihoonjung
added github handle element for Tien Yuan in heart.md (hackforla#7069)
89fa866
t-will-gillis added a commit that referenced this pull request Aug 18, 2024
@terrencejihoonjung @HackforLABot
@dcotelessa @santiseccovidal @t-will-gillis @jennisung @williamzhang73 @melissam640 @alabador @DakuwoN @Kle012 @cchrizzle @duojet2ez @mrodz @DrAcula27 @vanessasinam @aadilahmed
Update Team Meeting Data on Events Page to show Meeting Frequency (#7088
5cb891d 
)

* updated-team-meeting-data-6920

* Update contributor and language data

* Update contributor and language data

* Fix Capitalization of "Slack" in CONTRIBUTING.MD - line 582 (#7038)

* Update contributor and language data

* Modified spell-check-audit.md file, changed label Feature: Administrative to feature: spelling (#7036)

* PBB migration "Issue Trigger"  (#7053)

* Update issue-trigger.yml

Changes in prep for Projects Beta migration

* Update issue-trigger.yml

space added to comment

* Update issue-trigger.yml

edits to comment at Team Members

* Update preliminary-update-comment.js

refactoring for PBB migration

* PBB migration "Pull Request Trigger" (#7054)

* Update pull-request-trigger.yml

edits for PBB migration

* Update pull-request-trigger.yml

remove test branch

* PBB migration "Schedule Friday" (#7055)

* Update schedule-fri-0700.yml

Changes for PBB migration

* Update add-label.js

* Update find-linked-issue.js

For PBB migration

* Update add-label.js

remove refs to personal repo

* Update add-label.js

addressing CodeQL alert

* Update add-label.js

address CodeQL alert

* PBB migration "Move Closed Issues" (#7056)

* Update move-closed-issues.yaml

for migration to PBB

* Update sort-closed-issues.js

* Add github-handle for Roland Abregorivas in heart.md #6940 (#7009)

* github-handle variable added for Gian Reyes Dionisio #6937 (#6984)

* Update contributor and language data

* updated role for Will Gillis on website project profile (#7063)

* Add github handle for Marie (#7059)

* added github handle element for Tien Yuan in heart.md (#7069)

* Update contributor and language data

* Fixes #7046 Added github handle to _projects/heart.md for Jason LaManque.

* Update Roslyn's role to Developer Co-Lead (#7070)

* img Tag Refactor in Contributing.md page  (#7068)

* Update contributor and language data

* Added github-handle to Adrian Inchauste's section (#7074)

* Update contributor and language data

* edited Samantha Hyler to be Co-lead AND added Emma Thrash (#7040)

* 6786 remove bop from untaggedrepoids in get project datajs (#7062)

* remove references to BoP's id from the `untaggedRepoIds` list

* Update contributor and language data

* Revert `github.repository` post GHA test

* Resolve merge conflicts

* Resolve merge conflicts (p2)

---------

Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org>

* Update CONTRIBUTING.md Section 2.7.d with correct stream branch (#7082)

* Update meeting data

* Update contributor and language data

* Update Inactive Members JSON

* Revert "updated-team-meeting-data-6920 (#7043)" (#7086)

This reverts commit dc11c65.

* Update contributor and language data

* Update contributor and language data

* updated team meeting data on events page to show meeting frequency

* Add 'Leadership Option' to Issue Template for CoP Information Update (#7077)

* add leadership type option with dropdown fields

* remove whitespace between labels and body

* remove whitespace in title

* remove whitespace in front of the yes/no options

* change default type

* Update contributor and language data

* Updated spell checker to ignore memebers names (#7073)

* Update contributor and language data

* Update contributor and language data

* truncate contributors name in filter tag with ellipis (#7052)

* Update contributor and language data

---------

Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org>
Co-authored-by: David Cotelessa <david@cotelessa.com>
Co-authored-by: Santiago Secco <53095957+santisecco@users.noreply.github.com>
Co-authored-by: Will Gillis <40799239+t-will-gillis@users.noreply.github.com>
Co-authored-by: Jennifer Sung <72041281+jennisung@users.noreply.github.com>
Co-authored-by: williamzhang <willzhang73@gmail.com>
Co-authored-by: Melissa McGrath <157540251+melissam640@users.noreply.github.com>
Co-authored-by: Austin Labador <67137399+alabador@users.noreply.github.com>
Co-authored-by: Matthew McCane <78394982+DakuwoN@users.noreply.github.com>
Co-authored-by: Kim <109393217+Kle012@users.noreply.github.com>
Co-authored-by: Christopher Chang <64837366+cchrizzle@users.noreply.github.com>
Co-authored-by: duojet2ez <epstringskip@gmail.com>
Co-authored-by: Mateo Rodriguez <79176075+mrodz@users.noreply.github.com>
Co-authored-by: Danielle Andrews <62191468+DrAcula27@users.noreply.github.com>
Co-authored-by: vanessasinam <85697744+vanessasinam@users.noreply.github.com>
Co-authored-by: Aadil Ahmed <aadilahmed0@gmail.com>
This was referenced Aug 10, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@LRenDO LRenDO LRenDO approved these changes

@Anahisv23 Anahisv23 Anahisv23 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

P: HfLA Website: Project Board
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add github-handle element for Tien Yuan overview in project heart

3 participants

@melissam640 @Anahisv23 @LRenDO