Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: Throughout week |
andyphancode
left a comment
There was a problem hiding this comment.
- Changes in code appear correct
- Branching is correct
- PR summary contains necessary info
Everything looks good! Just wanted to ask for a more specific title for the Pull Request just for more organized book keeping. Maybe something like "Added github-handle to Tien Yuan section".
|
Availability: every day 9AM-8PM |
mrodz
left a comment
There was a problem hiding this comment.
Good job!
- Good source branch and destination branch
- Linked issue number
- No visual changes
- The new YAML property uses a delimiter of whitespaces
I concord with @andyphancode that the name of the PR should include at least Tien Yuan's name. Once you rename the PR, make sure to re-request our reviews so that we can get your work merged!
Thanks for your time :)
Fixes #7050
What changes did you make?
-Add github-handle: on heart.md file
Why did you make the changes (we will use this info to test)?
--This variable will eventually replace github and picture variables to reduce redundancy in the project file.
No visual changes to the website.