Skip to content

Add GitHub handle for Charlotte Soestini#6980

Merged
jphamtv merged 1 commit intohackforla:gh-pagesfrom
handshek:add-charlotte-gh-handle-6938
Jun 13, 2024
Merged

Add GitHub handle for Charlotte Soestini#6980
jphamtv merged 1 commit intohackforla:gh-pagesfrom
handshek:add-charlotte-gh-handle-6938

Conversation

@handshek
Copy link
Member

Fixes #6938

What changes did you make?

  • Added github-handle: for Charlotte Soestini:

Why did you make the changes (we will use this info to test)?

  • Create a single variable github-handle for each member of the leadership team to reduce redundancy in the project file.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • No visual changes.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b buneeIsSlo-add-charlotte-gh-handle-6938 gh-pages
git pull https://github.com/buneeIsSlo/website.git add-charlotte-gh-handle-6938

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jun 10, 2024
@pdimaano pdimaano self-requested a review June 10, 2024 18:21
@pdimaano
Copy link
Contributor

ETA: 6/13/24
Availability: Weekday evenings

Copy link
Contributor

@mSharifHub mSharifHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should add the name next to the github-handle like a key:value with no "" for example github-handle: msharifHub

@handshek
Copy link
Member Author

you should add the name next to the github-handle like a key:value with no "" for example github-handle: msharifHub

Sorry, but I don't think that's correct. According to this comment the intent is to add a new line with the variable github-handle and that's it.

Kindly read the instructions on the issue before reviewing.

@handshek handshek requested a review from mSharifHub June 11, 2024 04:07
@ino-iosdev
Copy link
Member

ino-iosdev commented Jun 12, 2024

you should add the name next to the github-handle like a key:value with no "" for example github-handle: msharifHub

@mSharifHub This is incorrect information, we had you revise yours to NOT include the name after github-handle: see example #6917, and please note that you are not supposed to do any PR review until your first PR has been approved and eventually merged. I dismissed your change request, could you please unassign yourself from your end? Thank you!

@buneeIsSlo You are good, no need to make changes on that. Thank you.

@ino-iosdev ino-iosdev removed the request for review from mSharifHub June 12, 2024 16:33
@ino-iosdev ino-iosdev dismissed mSharifHub’s stale review June 12, 2024 16:35

incorrect change request

@ino-iosdev ino-iosdev self-requested a review June 12, 2024 16:35
@ino-iosdev
Copy link
Member

ETA: EoD

@ino-iosdev
Copy link
Member

you should add the name next to the github-handle like a key:value with no "" for example github-handle: msharifHub

@ino-iosdev ino-iosdev closed this Jun 12, 2024
@ino-iosdev ino-iosdev reopened this Jun 12, 2024
@t-will-gillis
Copy link
Member

Hey @buneeIsSlo You are correct.

So there is no ambiguity: The issue specifies that only the text github-handle: should be added, and your code edits are correct.

Copy link
Member

@ino-iosdev ino-iosdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @buneeIsSlo , It's such a blessing to have you as part of the team here!
 

  • Branch naming was appropriate
  • Direction between branches from and to are clear
  • The changes and why were clear
  • PR issue ticket was properly linked
  • No visual changes to the website
     
    Great job, thank you for contributing!

Copy link
Member

@ino-iosdev ino-iosdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@buneeIsSlo

Just noticed one minor thing to change, please mark the actions in the original issue ticket, after that it's all good! Thank you so much! Please see reference below:

Screenshot 2024-06-12 at 2 47 54 PM

@handshek
Copy link
Member Author

@t-will-gillis Thank you for the clarification and the review :)

@ino-iosdev I Truly appreciate the kind words, and I'll be sure to mark the actions on the issue.

I look forward to contributing more!

@del9ra
Copy link
Member

del9ra commented Jun 13, 2024

Review ETA: 6 PM 6/13/24
Availability: 1-5 PM Monday - Friday

@del9ra del9ra self-requested a review June 13, 2024 17:53
Copy link
Member

@del9ra del9ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @buneeIsSlo,
Great job with this pull request!

  • The branching was done correctly
  • Issue number was listed
  • The PR title is descriptive of the changes
  • Changes were made correctly in the code
  • Note was left that there were no visual changes
    Again, nice work and thanks for taking the time to contribute to the website!

Copy link
Contributor

@pdimaano pdimaano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@buneeIsSlo Good job: The branches are correct and the issue is linked. The webpage still works on my system on desktop, mobile and tablet. The correct file was changed with the requested information. Well done!

@jphamtv jphamtv dismissed ino-iosdev’s stale review June 13, 2024 19:17

Confirmed action items were checked per request

@jphamtv jphamtv merged commit dcced49 into hackforla:gh-pages Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add github-handle for Charlotte Soestini in heart.md

7 participants