Add GitHub handle for Charlotte Soestini#6980
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
ETA: 6/13/24 |
mSharifHub
left a comment
There was a problem hiding this comment.
you should add the name next to the github-handle like a key:value with no "" for example github-handle: msharifHub
Sorry, but I don't think that's correct. According to this comment the intent is to add a new line with the variable Kindly read the instructions on the issue before reviewing. |
@mSharifHub This is incorrect information, we had you revise yours to NOT include the name after @buneeIsSlo You are good, no need to make changes on that. Thank you. |
|
ETA: EoD |
|
|
Hey @buneeIsSlo You are correct. So there is no ambiguity: The issue specifies that only the text |
ino-iosdev
left a comment
There was a problem hiding this comment.
Hi @buneeIsSlo , It's such a blessing to have you as part of the team here!
- Branch naming was appropriate
- Direction between branches
fromandtoare clear - The changes and why were clear
- PR issue ticket was properly linked
- No visual changes to the website
Great job, thank you for contributing!
ino-iosdev
left a comment
There was a problem hiding this comment.
|
@t-will-gillis Thank you for the clarification and the review :) @ino-iosdev I Truly appreciate the kind words, and I'll be sure to mark the actions on the issue. I look forward to contributing more! |
|
Review ETA: 6 PM 6/13/24 |
del9ra
left a comment
There was a problem hiding this comment.
Hey @buneeIsSlo,
Great job with this pull request!
- The branching was done correctly
- Issue number was listed
- The PR title is descriptive of the changes
- Changes were made correctly in the code
- Note was left that there were no visual changes
Again, nice work and thanks for taking the time to contribute to the website!
pdimaano
left a comment
There was a problem hiding this comment.
@buneeIsSlo Good job: The branches are correct and the issue is linked. The webpage still works on my system on desktop, mobile and tablet. The correct file was changed with the requested information. Well done!
Confirmed action items were checked per request

Fixes #6938
What changes did you make?
github-handle:for Charlotte Soestini:Why did you make the changes (we will use this info to test)?
github-handlefor each member of the leadership team to reduce redundancy in the project file.Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)