Skip to content

ER: Remove Extraneous $ in wins.js #8147

@dvernon5

Description

@dvernon5

Emergent Requirement - Problem

An invalid $ character is present in the wins.js file on line 31, causing a potential issue with the wins page functionality.

Issue you discovered this emergent requirement in

Date discovered

05/18/2025

Did you have to do something temporarily

  • YES
  • NO

Who was involved

@daras-cu

What happens if this is not addressed

Selecting I became part of a caring community on the Share your wins with us form, will cause the wins page to crash, disrupting the user experience.

Resources

  • wins.js file: website/assets/js/wins.js
  • Data file: website/_data/external/_wins-data.json
  • Icon file: website/assets/images/wins-page/wins-badges/community.svg
  • demo video by @daras-cu showing wins page user information update: video demo

Recommended Action Items

  • Make a new issue
  • Discuss with team
  • Let a Team Lead know

Potential solutions [draft]

  1. In website/assets/js/wins.js on line 31, update $community.svg to community.svg by removing the $ character.
  2. Develop a test procedure to verify that the wins page renders correctly when "I became part of a caring community." is selected in the "What do you want to celebrate (select all that apply)? field in website/_data/external/_wins-data.json.
    • The community.svg icon (website/assets/images/wins-page/wins-badges/community.svg) should display under the developer’s summary section if "I became part of a caring community." is included in their responses.
    • Hint: You may manually edit website/_data/external/_wins-data.json on a separate test branch to simulate a selection on the "Share your wins with us" form.
  3. In your PR, include an explanation of the testing you performed and relevant screenshots.

Sub-issues

Metadata

Metadata

Assignees

Labels

Complexity: MediumEREmergent RequestIssue Making: Level 2Make issue(s) from an ER or EpicP-Feature: Wins Pagehttps://www.hackforla.org/wins/ready for merge teamneeds a senior review either to do some re writing or to approve it for ready for prioritizationrole: back end/devOpsTasks for back-end developersrole: front endTasks for front end developerssize: 0.25ptCan be done in 0.5 to 1.5 hourstime sensitiveNeeds to be worked on by a particular timeframe

Type

No type

Projects

Status

QA

Relationships

None yet

Development

No branches or pull requests

Issue actions