Skip to content

Google Apps Script - Add Unique IDs to Wins entries#8121

Merged
t-will-gillis merged 23 commits intohackforla:gh-pagesfrom
daras-cu:apps-script-add-wins-ids-2385
May 18, 2025
Merged

Google Apps Script - Add Unique IDs to Wins entries#8121
t-will-gillis merged 23 commits intohackforla:gh-pagesfrom
daras-cu:apps-script-add-wins-ids-2385

Conversation

@daras-cu
Copy link
Member

@daras-cu daras-cu commented May 11, 2025

Fixes #2385

What changes did you make?

  • Added unique ID key based on spreadsheet row to each wins object when added to _wins-data.json
  • Added sorting to Responses sheet to ensure responses are always in the same row order

Why did you make the changes (we will use this info to test)?

  • To expedite finding a specific Wins entry

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

No visual changes

Reviewer instructions:

The added IDs in _wins-data.json must be tested on the daras-cu:test-wins branch. Do not pull from apps-script-add-wins-ids-2385 but instead use:

git checkout -b daras-cu-test-wins gh-pages
git pull https://github.com/daras-cu/website.git test-wins

Then run the site locally using Docker as normal and verify the Wins page is unchanged.

The entire Wins submission and approval process in my test repo can be seen in this video demo

@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Medium P-Feature: Wins Page https://www.hackforla.org/wins/ Feature: Google Apps Scripts Automation related to Google Apps Scripts labels May 11, 2025
@github-actions github-actions bot added size: 2pt Can be done in 7-12 hours 2 weeks inactive labels May 11, 2025
@daras-cu daras-cu marked this pull request as draft May 11, 2025 20:01
@daras-cu daras-cu marked this pull request as ready for review May 12, 2025 03:53
@DDVVPP DDVVPP self-requested a review May 12, 2025 21:15
@DDVVPP
Copy link
Member

DDVVPP commented May 12, 2025

Review ETA: 6 PM PDT Friday, March 16, 2025
Availability: 11 AM - 5 PM PDT M - F

@daras-cu daras-cu requested a review from dvernon5 May 14, 2025 02:09
@dvernon5
Copy link
Member

ETA: Thursday EOD
Availability: Monday - Friday: 12PM - 6PM

Copy link
Member

@DDVVPP DDVVPP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @daras-cu !

  • The PR is done with the correct branch
  • The PR title accurately describes the issue
  • There is a linked issue
  • The video demo is clear
  • IDs are present in the wins data object
  • The Wins page looks unchanged

*I checked out the test branch and verified the the presence of the IDs and the unchanged Wins page locally, however I did not test out adding a win since I don't have access to any of the forms

Copy link
Member

@dvernon5 dvernon5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daras-cu

Thank you for taking this issue. Everything looks great.

  • The IDs are correctly presented in the _wins-data.json file.
  • The Wins page remains unchanged on my end as well.

However, I currently don't have access to the Wins Form Admin Guide and Wins-form (Response Sheet) either.

Great job on resolving this!

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board May 15, 2025
@t-will-gillis t-will-gillis merged commit 7e27724 into hackforla:gh-pages May 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Medium Feature: Google Apps Scripts Automation related to Google Apps Scripts P-Feature: Wins Page https://www.hackforla.org/wins/ role: back end/devOps Tasks for back-end developers size: 2pt Can be done in 7-12 hours

Projects

Development

Successfully merging this pull request may close these issues.

Google Apps Script: Add unique IDs as object keys for each wins entry

4 participants