Google Apps Script - Add Unique IDs to Wins entries#8121
Merged
t-will-gillis merged 23 commits intohackforla:gh-pagesfrom May 18, 2025
Merged
Google Apps Script - Add Unique IDs to Wins entries#8121t-will-gillis merged 23 commits intohackforla:gh-pagesfrom
t-will-gillis merged 23 commits intohackforla:gh-pagesfrom
Conversation
Update wins-data.json via Google Apps Script
Update wins-data.json via Google Apps Script
Update wins-data.json via Google Apps Script
Update wins-data.json via Google Apps Script
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
Review ETA: 6 PM PDT Friday, March 16, 2025 |
Member
|
ETA: Thursday EOD |
DDVVPP
approved these changes
May 14, 2025
Member
DDVVPP
left a comment
There was a problem hiding this comment.
Looks great @daras-cu !
- The PR is done with the correct branch
- The PR title accurately describes the issue
- There is a linked issue
- The video demo is clear
- IDs are present in the wins data object
- The Wins page looks unchanged
*I checked out the test branch and verified the the presence of the IDs and the unchanged Wins page locally, however I did not test out adding a win since I don't have access to any of the forms
dvernon5
approved these changes
May 15, 2025
Member
dvernon5
left a comment
There was a problem hiding this comment.
Thank you for taking this issue. Everything looks great.
- The IDs are correctly presented in the
_wins-data.jsonfile. - The Wins page remains unchanged on my end as well.
However, I currently don't have access to the Wins Form Admin Guide and Wins-form (Response Sheet) either.
Great job on resolving this!
This was referenced May 15, 2025
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2385
What changes did you make?
_wins-data.jsonResponsessheet to ensure responses are always in the same row orderWhy did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
No visual changes
Reviewer instructions:
The added IDs in
_wins-data.jsonmust be tested on thedaras-cu:test-winsbranch. Do not pull fromapps-script-add-wins-ids-2385but instead use:Then run the site locally using Docker as normal and verify the Wins page is unchanged.
The entire Wins submission and approval process in my test repo can be seen in this video demo