Revert pr 2724 and pr 2672 to fix proj profile page bug#2757
Merged
SAUMILDHANKAR merged 2 commits intohackforla:gh-pagesfrom Feb 9, 2022
Conversation
…scss (hackforla#2724)" This reverts commit 3bc8d50.
This reverts commit 9b97a8b.
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
Bug
This was referenced Feb 9, 2022
SAUMILDHANKAR
approved these changes
Feb 9, 2022
Member
SAUMILDHANKAR
left a comment
SAUMILDHANKAR
left a comment
There was a problem hiding this comment.
@JessicaLucindaCheng Thanks Jessica for such a quick turnaround on this as well as identifying the root cause of the problem. Revert looks good on my environment and project pages are looking fine. Thank you.
JessicaLucindaCheng
deleted the
revert-pr-2724-and-pr-2672-to-fix-proj-profile-page-bug-2574
branch
17 tasks
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2754
What changes did you make and why did you make them?
Reverted pr #2724 and pr #2672 to fix the issue with the technologies field not being wrapped on the detail project profile page. This was caused by
id="technologies"being used by both the Languages/Technologies dropdown and the technologies field on the detail project profile page. However, this is only a temporary fix and the issue with the id="technologies" would still need to be addressed.Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Mobile view of Languages/Technologies dropdown
Desktop view of Languages/Technologies dropdown
Desktop view of 311 Data project page
Desktop view of Civic Tech Jobs project page
Desktop view of Civic Tech Index project page
Desktop view of Food Oasis project page
Visuals after changes are applied
Mobile view of Languages/Technologies dropdown
Desktop view of Languages/Technologies dropdown
Desktop view of 311 Data project page
Desktop view of Civic Tech Jobs project page
Desktop view of Civic Tech Index project page
Desktop view of Food Oasis project page
