Fixes SCSS #technologies#2761
Conversation
This reverts commit d41be43.
…_layout.scss (hackforla#2724)"" This reverts commit 17a63fc.
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
This comment was marked as outdated.
This comment was marked as outdated.
|
Review ETA: EOD 2/14/22 |
…, so that each menu item fits in 1 row and doesn't need to wrap
|
Revised Review ETA: EOD 2/19/22 |
|
@SAUMILDHANKAR I just pushed a commit and added the following to my original pr post:
Also, I updated the picture for the after visual for the dropdown with 3 columns. |
|
@SAUMILDHANKAR Also, added the following note to this comment: #2397 (comment)
|
|
Revised Review ETA: EOD 2/21/22 |
There was a problem hiding this comment.
@JessicaLucindaCheng Changes look good to me. I can see 3 columns for tech dropdown in desktop version. Project pages look fine as well. I will merge this to a new feature branch called feature-tech-dropdown. Next steps would be discussion regarding making the dropdown dynamic and any other changes required before merging this feature branch to gh-pages. Thanks a lot for working on this.
SAUMILDHANKAR
left a comment
There was a problem hiding this comment.
@JessicaLucindaCheng Changes look good to me. I can see 3 columns for tech dropdown in desktop version. Project pages look fine as well. I will merge this to a new feature branch called feature-tech-dropdown. Next steps would be discussion regarding making the dropdown dynamic and any other changes required before merging this feature branch to gh-pages. Thanks a lot for working on this.
Fixes #2754 and #2397
What changes did you make and why did you make them?
#technologiestoul.dropdown#technologiesbecauseul.dropdown#technologieshas a higher specificity than#technologies. Also, SCSS#technologiescaused problems with the technologies field on the detailed project page since it also has anid="technologies"; this caused a problem because all the SCSS files are compiled into a main.scss, which is shared sitewide by all webpages.ul.filter-list li ulandul.dropdown#technologiesinto one @media #{$bp-below-tablet} to make it so there wasn't multiple media queries with the same$bp-below-tabletparameter.Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Mobile view of Languages/Technologies dropdown

Desktop view of Languages/Technologies dropdown

Desktop view of 311 Data project page

Desktop view of Civic Tech Jobs project page

Desktop view of Civic Tech Index project page

Desktop view of Food Oasis project page

Visuals after changes are applied
Mobile view of Languages/Technologies dropdown

Desktop view of Languages/Technologies dropdown

Desktop view of 311 Data project page (should look the same as the before image and putting it here to show it is the same)

Desktop view of Civic Tech Jobs project page (should look the same as the before image and putting it here to show it is the same)

Desktop view of Civic Tech Index project page (should look the same as the before image and putting it here to show it is the same)

Desktop view of Food Oasis project page (should look the same as the before image and putting it here to show it is the same)
