Update add labels trigger #2939

[poorvi4]

Fixes #2939

What changes did you make and why did you make them ?

Modified add-labels-template.md to include note to notify users who do not have write access to repository to ignore the 'add labels' section

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Visuals after changes are applied

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b poorvi4-update-add-labels-trigger-2939 gh-pages
git pull https://github.com/poorvi4/website.git update-add-labels-trigger-2939

[kathrynsilvaconway]

Availability: 1 hour
ETA: By the end of 4/11

[Sparky-code]

Availability: 1hr
ETA: 4.11 EOD

[Sparky-code]

Hey @poorvi4, Everything looks great! Tested the changes locally and it worked as expected, file appears to trigger normally with the additional text.

Visuals before changes are applied

)

Visuals after changes are applied

[kathrynsilvaconway]

Nice Work adding this clarification to the add labels template. I can see your changes display correctly, no problems there.

For added clarity, it might be better to move the note directly under the step that has to be ignored. If a user is follwing the driections step by step, they might spend time trying to figure out how to add a label before they notice it at the bottom. @SAUMILDHANKAR, do you have a preference?

Otherwise, it looks good.

[Sparky-code]

@kathrynsilvaconway Thats a good point, I would agree with you on that.

Maybe underneath the second line:

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing: ${labels}
NOTE: If you do not have 'write' access to this directory, please ignore the adding proper labels comment.

[SAUMILDHANKAR]

@kathrynsilvaconway I wanted to leave the issue action item open ended and let a developer be the best judge of how to implement this but your suggestion is really helpful (would definitely save user's time). Thanks for bringing it up.

[poorvi4]

@kathrynsilvaconway that's a great suggestion! I agree with Saumil that it'll ease in readability. Will incorporate those changes

[kathrynsilvaconway]

@kathrynsilvaconway that's a great suggestion! I agree with Saumil that it'll ease in readability. Will incorporate those changes

Don't forget to request a a re-review when you're ready and I will approve it.

[kathrynsilvaconway]

@poorvi4 Nice work adding this this update to the add labels trigger message. Everything looks good!