Remove type field 2793#3079
Merged
tamara-snyder merged 3 commits intohackforla:gh-pagesfrom Apr 26, 2022
Merged
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
JessicaLucindaCheng
requested review from
kathrynsilvaconway and
trishajjohnson
Member
|
ETA: End of the day on 4/24. |
Member
|
@trishajjohnson
|
Member
|
ETA: end of day 4/24 |
kathrynsilvaconway
approved these changes
Apr 25, 2022
Member
kathrynsilvaconway
left a comment
kathrynsilvaconway
left a comment
There was a problem hiding this comment.
Hi, @matt-arofin. Congratulations on completing your first HFLA issue. I see that your have removed the type field from the avatar.yml file and renamed content field as "content-type." Nice work, everything looks good.
trishajjohnson
approved these changes
Apr 25, 2022
Member
There was a problem hiding this comment.
Hey @matt-arofin. Just took a look at your PR, everything looks great! The to and from branches are correct, you provided a linked issue and your explanation of tasks accomplished was clear and to the point. I pulled your branch and took a look at it and it appears that the page is in working order for all views, nothing broken or out of place, and comparing the files changed, everything seems to be in order.
Great first issue and congrats on completing your first PR!
JessicaLucindaCheng
added a commit
to JessicaLucindaCheng/website
that referenced
this pull request
May 13, 2022
* Update meeting data * Update meeting data * Update contributor and language data * Added few points to issue progression action item Added few points to issue progression action item * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Update add labels trigger hackforla#2939 (hackforla#3042) * Update add-labels-template.md * Update add-labels-template.md Rearranged original note * Update open-community-survey.md * Updated pre-work developer template * Changed typo in _projects/home-unite-us.md from 'non-profits' to 'nonprofits'. (hackforla#3062) * Update meeting data * Update contributor and language data * fixed the spelling of sustainability (hackforla#3067) * Update pre-work dev issue template * Update meeting data * Update contributor and language data * Update issue templates Added Wiki: Research Plan Review: [REPLACE WITH NAME OF PAGE] * Updated Project Profile Card review and update issue template * Update issue templates updated designer time * Updated Credits file template: Edit content field and remove type field * Updated Credits file template: Edit content field and remove type field * Update meeting data * Update contributor and language data * Fix misspelling of "community" on line 93 of pages/join-us.html (hackforla#3072) * Update meeting data * Update contributor and language data * Added feature-tech-dropdown branch * Update meeting data * Added feature-tech-dropdown branch * Added feature-tech-dropdown branch * Update contributor and language data * changed the spelling from webapp to web app on line 56 (hackforla#3073) * Update meeting data * Update contributor and language data * Revert " changed the spelling from webapp to web app on line 56 (hackforla#3073)" (hackforla#3078) This reverts commit f6deeff. * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Edit content field and remove type field from avatar.yml credits file 2793 (hackforla#3079) * Delete unused project-filter.js file (hackforla#3081) * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * fixed spelling of non-profit to nonprofit, line 77, join-us.html (hackforla#3076) * fixed spelling of non-profit to nonprofit, line 77, join-us.html * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Add so go survey credit page 3022 (hackforla#3043) * add new headers and tools section to credit page * updated to empty alt tags for tools section * fix snytax errors * fix spacing in code and website page * Fix indentation and add functionality for additional teams in "By:" field * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Edited items on how to pick up your first issue. Edited items on how to pick up your first issue. * Create new Privacy Policy page and its credit, and edit label (hackforla#3083) * Added privacy-policy.jpg * Add privacy-policy.yml to credits * Added initial privacy-policy scss and html files * Added header and overview section * Redoing the html page from scratch * Added a line in main.scss to import privacy-policy.scss * Added header section * Added the content for section Visiting HackforLA.org * Added content for section Email Addresses * Added content for Google Analytics section * Added content up through and including Third party service providers section * Finished adding all the content in the HTML file * Moved the import of privacy-policy.scss to the bottom of the components section Reason is it didn't make sense that I just put it in the middle on the components section without any reason. * Added styling for desktop version of page * Added mobile styling and finished desktop styling * Updated privacy-policy.yml credit * Fixed styling * Fixed styling * Added spacing before the address on the bottom of the page * Clarified "Project Profile Card review and update" template * Update meeting data * Update contributor and language data Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org> Co-authored-by: Saumil Dhankar <saumil.dhankar@yahoo.com> Co-authored-by: Poorvi Rao <41170744+poorvi4@users.noreply.github.com> Co-authored-by: Bonnie Wolfe <37763229+ExperimentsInHonesty@users.noreply.github.com> Co-authored-by: Wilny Duong <32424251+Wny-Duong@users.noreply.github.com> Co-authored-by: gardenqu <86074391+gardenqu@users.noreply.github.com> Co-authored-by: Simone Campbell <70714034+sacamp@users.noreply.github.com> Co-authored-by: Trisha Johnson <66317088+trishajjohnson@users.noreply.github.com> Co-authored-by: Erick Odero <84427589+eodero@users.noreply.github.com> Co-authored-by: Devin Krizwold <95888938+Sparky-code@users.noreply.github.com> Co-authored-by: Matthew Arofin <98365396+matt-arofin@users.noreply.github.com> Co-authored-by: Jay Barbanel <89555843+JayBarbanel@users.noreply.github.com> Co-authored-by: Jaret Balba <93153059+Jaretzbalba@users.noreply.github.com>
JessicaLucindaCheng
added a commit
to JessicaLucindaCheng/website
that referenced
this pull request
May 13, 2022
* Homepage redesign (hackforla#2373) * Adds communities of practice icons * Adds COP icons to credits * Links icons to CoP yml * Update nav link * Add communities icons for home page * create new contact use section * create new hero section of home page * create home page communities section * create home page join us section * create mvp for home page program areas * Adds anchor for home page links * adds new home page technology section * create home page wins section with wins card * restyles home age for redesign * Update program areas images * Add border radius to containers * Update padding on embrace section * Hero mobile design * Remove join text on mobile view * Fix join text on tablet-up * Remove contact text on mobiel view * Develop mobile technologies section' * Fix header padding * Update hero CoP icons credits links * Update hero CoP icons credits links * Communities section mobile version * Create small button element * Final communities section gradient fix * Random homepage win logic: * Hide horizontal sidebars to match design * Reposition homepage win overlay * Resolve filename typo * Change dataKey to match JSON variable * Reposition home join us header * Update photo for Civic Tech Infrastructure * Use new _wins-data * Update image link to use absolute_url variable * Add homepage program areas links * Refactor home wins js for _wins-data * Disable link leading to about page * Fix broken link path * Remove about page link from main nav * Move nav button styling to appropriate selector * Sm 1 feature homepage launch (#18) * Update meeting data * Update meeting data * Update contributor and language data * Added few points to issue progression action item Added few points to issue progression action item * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Update add labels trigger hackforla#2939 (hackforla#3042) * Update add-labels-template.md * Update add-labels-template.md Rearranged original note * Update open-community-survey.md * Updated pre-work developer template * Changed typo in _projects/home-unite-us.md from 'non-profits' to 'nonprofits'. (hackforla#3062) * Update meeting data * Update contributor and language data * fixed the spelling of sustainability (hackforla#3067) * Update pre-work dev issue template * Update meeting data * Update contributor and language data * Update issue templates Added Wiki: Research Plan Review: [REPLACE WITH NAME OF PAGE] * Updated Project Profile Card review and update issue template * Update issue templates updated designer time * Updated Credits file template: Edit content field and remove type field * Updated Credits file template: Edit content field and remove type field * Update meeting data * Update contributor and language data * Fix misspelling of "community" on line 93 of pages/join-us.html (hackforla#3072) * Update meeting data * Update contributor and language data * Added feature-tech-dropdown branch * Update meeting data * Added feature-tech-dropdown branch * Added feature-tech-dropdown branch * Update contributor and language data * changed the spelling from webapp to web app on line 56 (hackforla#3073) * Update meeting data * Update contributor and language data * Revert " changed the spelling from webapp to web app on line 56 (hackforla#3073)" (hackforla#3078) This reverts commit f6deeff. * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Edit content field and remove type field from avatar.yml credits file 2793 (hackforla#3079) * Delete unused project-filter.js file (hackforla#3081) * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * fixed spelling of non-profit to nonprofit, line 77, join-us.html (hackforla#3076) * fixed spelling of non-profit to nonprofit, line 77, join-us.html * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Add so go survey credit page 3022 (hackforla#3043) * add new headers and tools section to credit page * updated to empty alt tags for tools section * fix snytax errors * fix spacing in code and website page * Fix indentation and add functionality for additional teams in "By:" field * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Edited items on how to pick up your first issue. Edited items on how to pick up your first issue. * Create new Privacy Policy page and its credit, and edit label (hackforla#3083) * Added privacy-policy.jpg * Add privacy-policy.yml to credits * Added initial privacy-policy scss and html files * Added header and overview section * Redoing the html page from scratch * Added a line in main.scss to import privacy-policy.scss * Added header section * Added the content for section Visiting HackforLA.org * Added content for section Email Addresses * Added content for Google Analytics section * Added content up through and including Third party service providers section * Finished adding all the content in the HTML file * Moved the import of privacy-policy.scss to the bottom of the components section Reason is it didn't make sense that I just put it in the middle on the components section without any reason. * Added styling for desktop version of page * Added mobile styling and finished desktop styling * Updated privacy-policy.yml credit * Fixed styling * Fixed styling * Added spacing before the address on the bottom of the page * Clarified "Project Profile Card review and update" template * Update meeting data * Update contributor and language data Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org> Co-authored-by: Saumil Dhankar <saumil.dhankar@yahoo.com> Co-authored-by: Poorvi Rao <41170744+poorvi4@users.noreply.github.com> Co-authored-by: Bonnie Wolfe <37763229+ExperimentsInHonesty@users.noreply.github.com> Co-authored-by: Wilny Duong <32424251+Wny-Duong@users.noreply.github.com> Co-authored-by: gardenqu <86074391+gardenqu@users.noreply.github.com> Co-authored-by: Simone Campbell <70714034+sacamp@users.noreply.github.com> Co-authored-by: Trisha Johnson <66317088+trishajjohnson@users.noreply.github.com> Co-authored-by: Erick Odero <84427589+eodero@users.noreply.github.com> Co-authored-by: Devin Krizwold <95888938+Sparky-code@users.noreply.github.com> Co-authored-by: Matthew Arofin <98365396+matt-arofin@users.noreply.github.com> Co-authored-by: Jay Barbanel <89555843+JayBarbanel@users.noreply.github.com> Co-authored-by: Jaret Balba <93153059+Jaretzbalba@users.noreply.github.com> Co-authored-by: Sarah W <40401149+arghmatey@users.noreply.github.com> Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org> Co-authored-by: Saumil Dhankar <saumil.dhankar@yahoo.com> Co-authored-by: Poorvi Rao <41170744+poorvi4@users.noreply.github.com> Co-authored-by: Bonnie Wolfe <37763229+ExperimentsInHonesty@users.noreply.github.com> Co-authored-by: Wilny Duong <32424251+Wny-Duong@users.noreply.github.com> Co-authored-by: gardenqu <86074391+gardenqu@users.noreply.github.com> Co-authored-by: Simone Campbell <70714034+sacamp@users.noreply.github.com> Co-authored-by: Trisha Johnson <66317088+trishajjohnson@users.noreply.github.com> Co-authored-by: Erick Odero <84427589+eodero@users.noreply.github.com> Co-authored-by: Devin Krizwold <95888938+Sparky-code@users.noreply.github.com> Co-authored-by: Matthew Arofin <98365396+matt-arofin@users.noreply.github.com> Co-authored-by: Jay Barbanel <89555843+JayBarbanel@users.noreply.github.com> Co-authored-by: Jaret Balba <93153059+Jaretzbalba@users.noreply.github.com>
JessicaLucindaCheng
added a commit
to JessicaLucindaCheng/website
that referenced
this pull request
May 14, 2022
* Update meeting data * Update meeting data * Update contributor and language data * Added few points to issue progression action item Added few points to issue progression action item * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Update add labels trigger hackforla#2939 (hackforla#3042) * Update add-labels-template.md * Update add-labels-template.md Rearranged original note * Update open-community-survey.md * Updated pre-work developer template * Changed typo in _projects/home-unite-us.md from 'non-profits' to 'nonprofits'. (hackforla#3062) * Update meeting data * Update contributor and language data * fixed the spelling of sustainability (hackforla#3067) * Update pre-work dev issue template * Update meeting data * Update contributor and language data * Update issue templates Added Wiki: Research Plan Review: [REPLACE WITH NAME OF PAGE] * Updated Project Profile Card review and update issue template * Update issue templates updated designer time * Updated Credits file template: Edit content field and remove type field * Updated Credits file template: Edit content field and remove type field * Update meeting data * Update contributor and language data * Fix misspelling of "community" on line 93 of pages/join-us.html (hackforla#3072) * Update meeting data * Update contributor and language data * Added feature-tech-dropdown branch * Update meeting data * Added feature-tech-dropdown branch * Added feature-tech-dropdown branch * Update contributor and language data * changed the spelling from webapp to web app on line 56 (hackforla#3073) * Update meeting data * Update contributor and language data * Revert " changed the spelling from webapp to web app on line 56 (hackforla#3073)" (hackforla#3078) This reverts commit f6deeff. * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Edit content field and remove type field from avatar.yml credits file 2793 (hackforla#3079) * Delete unused project-filter.js file (hackforla#3081) * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * fixed spelling of non-profit to nonprofit, line 77, join-us.html (hackforla#3076) * fixed spelling of non-profit to nonprofit, line 77, join-us.html * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Add so go survey credit page 3022 (hackforla#3043) * add new headers and tools section to credit page * updated to empty alt tags for tools section * fix snytax errors * fix spacing in code and website page * Fix indentation and add functionality for additional teams in "By:" field * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Edited items on how to pick up your first issue. Edited items on how to pick up your first issue. * Create new Privacy Policy page and its credit, and edit label (hackforla#3083) * Added privacy-policy.jpg * Add privacy-policy.yml to credits * Added initial privacy-policy scss and html files * Added header and overview section * Redoing the html page from scratch * Added a line in main.scss to import privacy-policy.scss * Added header section * Added the content for section Visiting HackforLA.org * Added content for section Email Addresses * Added content for Google Analytics section * Added content up through and including Third party service providers section * Finished adding all the content in the HTML file * Moved the import of privacy-policy.scss to the bottom of the components section Reason is it didn't make sense that I just put it in the middle on the components section without any reason. * Added styling for desktop version of page * Added mobile styling and finished desktop styling * Updated privacy-policy.yml credit * Fixed styling * Fixed styling * Added spacing before the address on the bottom of the page * Clarified "Project Profile Card review and update" template * Update meeting data * Update contributor and language data Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org> Co-authored-by: Saumil Dhankar <saumil.dhankar@yahoo.com> Co-authored-by: Poorvi Rao <41170744+poorvi4@users.noreply.github.com> Co-authored-by: Bonnie Wolfe <37763229+ExperimentsInHonesty@users.noreply.github.com> Co-authored-by: Wilny Duong <32424251+Wny-Duong@users.noreply.github.com> Co-authored-by: gardenqu <86074391+gardenqu@users.noreply.github.com> Co-authored-by: Simone Campbell <70714034+sacamp@users.noreply.github.com> Co-authored-by: Trisha Johnson <66317088+trishajjohnson@users.noreply.github.com> Co-authored-by: Erick Odero <84427589+eodero@users.noreply.github.com> Co-authored-by: Devin Krizwold <95888938+Sparky-code@users.noreply.github.com> Co-authored-by: Matthew Arofin <98365396+matt-arofin@users.noreply.github.com> Co-authored-by: Jay Barbanel <89555843+JayBarbanel@users.noreply.github.com> Co-authored-by: Jaret Balba <93153059+Jaretzbalba@users.noreply.github.com>
This was referenced Aug 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2793
What changes did you make and why did you make them ?
_data/internal/credits/avatar.ymlbecause it is now redundant_data/internal/credits/avatar.ymlto make its purpose clearer for devsScreenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Edited a credits yml file to add clarity to its fields. No visual changes to the website.