Skip to content

Updated viewport widths#4796

Merged
drakenguyen4000 merged 1 commit intohackforla:gh-pagesfrom
one2code:fix-nav-header-fractional-viewports-issue-3975
Jun 18, 2023
Merged

Updated viewport widths#4796
drakenguyen4000 merged 1 commit intohackforla:gh-pagesfrom
one2code:fix-nav-header-fractional-viewports-issue-3975

Conversation

@one2code
Copy link
Member

Fixes #3975

In Sass/variables/_layout.scss, I changed the fractional viewport value from -1 to -.02 on the following variables:
$bp-below-desktop-large: '(max-width: #{$screen-desktop-large - .02})'
$bp-below-desktop: '(max-width: #{$screen-desktop - .02})';
$bp-below-tablet: '(max-width: #{$screen-tablet - .02})';
$bp-below-mobile: '(max-width: #{$screen-mobile - .02})';

Screenshots of Proposed Changes Of The Website

Visuals before changes are applied

nav_before_changes

Visuals after changes are applied

after_nav_changes

I continued testing across the website in Docker, loading every route. During testing, I observed no unexpected visual changes. The header and nav displayed correctly with the new changes across every page on the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b one2code-fix-nav-header-fractional-viewports-issue-3975 gh-pages
git pull https://github.com/one2code/website.git fix-nav-header-fractional-viewports-issue-3975

@github-actions github-actions bot added role: front end Tasks for front end developers P-Feature: Navigation Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 2pt Can be done in 7-12 hours labels Jun 10, 2023
@roslynwythe roslynwythe requested review from rdhmdhl and roslynwythe and removed request for roslynwythe June 11, 2023 17:23
@roslynwythe
Copy link
Member

Hi @one2code I'm removing myself as a reviewer because I could not reproduce the problem on my system.

@steven-positive-tran
Copy link
Member

ETA: 6/14/23

@steven-positive-tran steven-positive-tran self-requested a review June 13, 2023 23:57
@rdhmdhl
Copy link
Contributor

rdhmdhl commented Jun 14, 2023

Hi @one2code I'm also not able to replicate this in my browser using the live website. At the width of 767px, the menu is showing up in the correct location.

@rdhmdhl rdhmdhl removed their request for review June 14, 2023 00:51
@blulady blulady requested a review from mademarc June 14, 2023 02:17
Copy link
Member

@steven-positive-tran steven-positive-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking up this issue for hack for la.

I no longer see that bug once I go reach that 767px point on both Firefox and Edge. Code changes seems in line with the immediate solution of the problem. Branches look good and I don't see a page where the changes are breaking the site.

Looks good for me

@mademarc
Copy link
Member

Review ETA: 6/15/2023
Availability: 7:12PM

Copy link
Member

@mademarc mademarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @one2code the changes on the 20, 22, 24 & 26 lines look very good on making the page look great as well.

@drakenguyen4000
Copy link
Member

Nicely done @one2code. Code changed as outlined, addressed issue's scope, and there is no unintended side effects on elements of all pages.

@drakenguyen4000 drakenguyen4000 merged commit 47d54b2 into hackforla:gh-pages Jun 18, 2023
blulady pushed a commit to blulady/website_old that referenced this pull request Jun 18, 2023
blulady pushed a commit to blulady/website_old that referenced this pull request Jun 18, 2023
blulady pushed a commit to blulady/website_old that referenced this pull request Jun 18, 2023
blulady pushed a commit to blulady/website_old that referenced this pull request Jun 18, 2023
blulady pushed a commit to blulady/website_old that referenced this pull request Jun 18, 2023
@one2code one2code deleted the fix-nav-header-fractional-viewports-issue-3975 branch June 21, 2023 00:53
ronaldpaek pushed a commit to ronaldpaek/website that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Navigation role: front end Tasks for front end developers size: 2pt Can be done in 7-12 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Hack for LA Website Header and Nav Menu at Fractional Viewport Widths

6 participants