Skip to content

Refactored project page to fix formatting issues#4897

Merged
drakenguyen4000 merged 1 commit intohackforla:gh-pagesfrom
ldietz08:refactor-project-page-4859
Jul 2, 2023
Merged

Refactored project page to fix formatting issues#4897
drakenguyen4000 merged 1 commit intohackforla:gh-pagesfrom
ldietz08:refactor-project-page-4859

Conversation

@ldietz08
Copy link
Member

@ldietz08 ldietz08 commented Jun 28, 2023

Fixes #4859

What changes did you make?

  • Added a code snippet to the project page to align with the newly implemented data format for tools.
  • The main change involves adding a for loop to iterate over each item in page.tools.

Why did you make the changes (we will use this info to test)?

  • To provide a more flexible approach for rendering the page.tools data as a formatted list.

No visual changes made to the site.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ldietz08-refactor-project-page-4859 gh-pages
git pull https://github.com/ldietz08/website.git refactor-project-page-4859

@github-actions github-actions bot added role: front end Tasks for front end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less labels Jun 28, 2023
@LOSjr4 LOSjr4 self-requested a review June 29, 2023 03:20
Copy link
Member

@LOSjr4 LOSjr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request was done with the correct branch and the issue is linked. The tools section of the project pages appear to display correctly using Docker. The code matches the proposed code provided on the issue.
@ldietz08 , images in the PR description are to show visual changes. I figured you provided the image because the issue asked you to verify the code displayed correctly, but adding the image was not needed. I do appreciate a thorough description though.
Thank you for picking up this issue.

@chrismenke45 chrismenke45 self-requested a review June 29, 2023 17:04
@chrismenke45
Copy link
Member

Review ETA: Noon today
Availability: Now-Noon today

Copy link
Member

@chrismenke45 chrismenke45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The site doesn't have any changes and the code is correct!

@drakenguyen4000
Copy link
Member

Code changes were made correctly as requested. Good work @ldietz08.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less time sensitive Needs to be worked on by a particular timeframe

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor project page to fix any formatting issues with new tools data format

5 participants