-
-
Notifications
You must be signed in to change notification settings - Fork 847
Closed
Labels
Complexity: SmallTake this type of issues after the successful merge of your second good first issueTake this type of issues after the successful merge of your second good first issueFeature: Refactor JS / LiquidPage is working fine - JS / Liquid needs changes to become consistent with other pagesPage is working fine - JS / Liquid needs changes to become consistent with other pagesP-Feature: Project Info and PageA project's detail page (e.g. https://www.hackforla.org/projects/100-automations)A project's detail page (e.g. https://www.hackforla.org/projects/100-automations)role: front endTasks for front end developersTasks for front end developerssize: 0.5ptCan be done in 3 hours or lessCan be done in 3 hours or lesstime sensitiveNeeds to be worked on by a particular timeframeNeeds to be worked on by a particular timeframe
Milestone
Description
Dependency
Overview
This task involves refactoring the code referencing page.tools to align with the newly implemented data format for tools. The modifications aim to ensure correct display, accommodating spaces in the new data structure.
Action Items
- Refer to project.html and locate where tools is being referenced
- Refactor this code since tools till now be an Array so we need to map over every value
{% if page.tools %}<p><strong>Tools: </strong>{{ page.tools }}</p>{% endif %}
to
{% if page.tools %}
<p id='tools'>
<strong>Tools: </strong>
{% for tool in page.tools %}
{{ tool }}{% if forloop.last == false %},{% endif %}
{% endfor %}
</p>
{% endif %}
Making this change will ensure tools section renders correctly with the new data format of tools
- Once the change is made, confirm that Tools data is rendering correctly/ as before on individual project pages.
Resources/Instructions
- Projects page
- Liquid template language
- This issue is part of an epic: Add a Tools filter to the projects check page #4427
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Complexity: SmallTake this type of issues after the successful merge of your second good first issueTake this type of issues after the successful merge of your second good first issueFeature: Refactor JS / LiquidPage is working fine - JS / Liquid needs changes to become consistent with other pagesPage is working fine - JS / Liquid needs changes to become consistent with other pagesP-Feature: Project Info and PageA project's detail page (e.g. https://www.hackforla.org/projects/100-automations)A project's detail page (e.g. https://www.hackforla.org/projects/100-automations)role: front endTasks for front end developersTasks for front end developerssize: 0.5ptCan be done in 3 hours or lessCan be done in 3 hours or lesstime sensitiveNeeds to be worked on by a particular timeframeNeeds to be worked on by a particular timeframe
Type
Projects
Status
Done
