Skip to content

Add new variable github-handle for member Jason Brown in 100-automations.md #5563

Merged
roslynwythe merged 2 commits intohackforla:gh-pagesfrom
aramattamara:add-github-handle-5509
Sep 28, 2023
Merged

Add new variable github-handle for member Jason Brown in 100-automations.md #5563
roslynwythe merged 2 commits intohackforla:gh-pagesfrom
aramattamara:add-github-handle-5509

Conversation

@aramattamara
Copy link
Member

@aramattamara aramattamara commented Sep 20, 2023

Fixes #5509

What changes did you make?

  • Add github-handle to 100-automations.md

Why did you make the changes (we will use this info to test)?

Confirmed that the appearance of the project webpage is unchanged at all screen sizes.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b aramattamara-add-github-handle-5509 gh-pages
git pull https://github.com/aramattamara/website.git add-github-handle-5509

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 20, 2023
@aramattamara aramattamara changed the title Add github-handle to 100-automations.md Add new variable github-handle for member Jason Brown in 100-automations.md Sep 20, 2023
@KyleA99 KyleA99 self-requested a review September 24, 2023 04:01
@KyleA99
Copy link
Member

KyleA99 commented Sep 24, 2023

Review ETA: 6 PM 9/24/23
Availability: 11 AM-6 PM Sunday

KyleA99
KyleA99 previously approved these changes Sep 24, 2023
Copy link
Member

@KyleA99 KyleA99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved. Looks great @aramattamara

@KyleA99 KyleA99 marked this pull request as draft September 25, 2023 19:53
@KyleA99 KyleA99 marked this pull request as ready for review September 25, 2023 20:03
@KyleA99
Copy link
Member

KyleA99 commented Sep 25, 2023

@ajb176 @roslynwythe @MattChau01 visual issue is not appearing on this page (aramattamara did not pre-fix github variable with "-"). The presence of "-" prefix may cause issues with how these markdown files are being parsed?

@aramattamara fyi we encountered an issue described in comments of #5565 so I wanted to update others as your PR is very similar.

@blulady blulady requested a review from agutiernc September 27, 2023 02:28
@roslynwythe roslynwythe self-requested a review September 27, 2023 02:30
@roslynwythe
Copy link
Member

@aramattamara @KyleA99 @agutiernc There is an error in the original issue and it will be updated shortly. In the meantime please do not review or merge. Thank you.

Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aramattamara I apologize for the error in the original issue. It has been updated along with a new comment. It looks like you correctly added the github-handle variable, however the intention for this good first issue was simply to place the variable, and not to populate the variable and replace the previous variables. Eventually, when the code has been modified, all of those changes will be made but for now I have to ask that you make only the exact change specified in the issue. Thank you

@agutiernc agutiernc removed their request for review September 27, 2023 19:08
Copy link
Member

@KyleA99 KyleA99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice work @aramattamara

Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @aramattamara for excellent work on this issue. Your code is correct and clean and checkes out perfectly in the browser. The PR is descriptive and the branches are setup correctly. We appreciate your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new variable github-handle for member Jason Brown in 100-automations.md

3 participants