Add new variable github-handle for member Jason Brown in 100-automations.md #5563
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 6 PM 9/24/23 |
KyleA99
left a comment
There was a problem hiding this comment.
Reviewed and approved. Looks great @aramattamara
|
@ajb176 @roslynwythe @MattChau01 visual issue is not appearing on this page (aramattamara did not pre-fix github variable with "-"). The presence of "-" prefix may cause issues with how these markdown files are being parsed? @aramattamara fyi we encountered an issue described in comments of #5565 so I wanted to update others as your PR is very similar. |
|
@aramattamara @KyleA99 @agutiernc There is an error in the original issue and it will be updated shortly. In the meantime please do not review or merge. Thank you. |
There was a problem hiding this comment.
@aramattamara I apologize for the error in the original issue. It has been updated along with a new comment. It looks like you correctly added the github-handle variable, however the intention for this good first issue was simply to place the variable, and not to populate the variable and replace the previous variables. Eventually, when the code has been modified, all of those changes will be made but for now I have to ask that you make only the exact change specified in the issue. Thank you
KyleA99
left a comment
There was a problem hiding this comment.
Looks good to me. Nice work @aramattamara
roslynwythe
left a comment
There was a problem hiding this comment.
Thank you @aramattamara for excellent work on this issue. Your code is correct and clean and checkes out perfectly in the browser. The PR is descriptive and the branches are setup correctly. We appreciate your contributions!
Fixes #5509
What changes did you make?
Why did you make the changes (we will use this info to test)?
Confirmed that the appearance of the project webpage is unchanged at all screen sizes.