Add github-handle variable in _projects/100-automations.md#5565
Add github-handle variable in _projects/100-automations.md#5565kwangric merged 4 commits intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: Evening Saturday, most of the day Sunday |
|
@MattChau01 @roslynwythe Should there be an actual github-handle value declared for this variable? Reviewing a similar PR right now and noticed that they added a value, whereas, my issue left it blank. Just wanted to confirm this was intentional. |
|
Hi @KyleA99 ! Would you mind providing the reference number for the other PR you saw? It could be a different scenario for that other issue. But would like to hear @roslynwythe for advice as well! |
|
@MattChau01 Here is the issue #5509 And corresponding PR #5563 |
|
@MattChau01 you're right, I mistakenly thought it was in the original issue. I'll reach out and update you once I hear back |
|
@KyleA99 No worries, glad to help out! |
|
I'm seeing some unwanted visual changes, even though Kyle edited the markdown file as suggested. The box containing the person's data seems to split into two. Does this issue occur for anyone else? @tonyvang first noticed this issue here in another issue of the same template, and their PR omitted the '-' before '- githhub-handle-' and kept it in line with 'role' and 'links'. Their PR didn't cause any visual changes, but it was slightly different from the instructions in the linked issue. @roslynwythe could you let me know if you're able to see this issue when reviewing this PR, because if so the original template may need to be slightly changed. |
|
@ajb176 I can see that unwanted visual change as well. Somehow missed that when I created the PR. I will check if this issue is also present in the PR I reviewed. |
|
@MattChau01 @KyleA99 @ajb176 There is an error in the original issue and it will be updated shortly. In the meantime please do not review or merge. Thank you |
roslynwythe
left a comment
There was a problem hiding this comment.
@KyleA99 Please see the updated issue and my comment in the issue. I apologize for the error and want to thank @ajb176 @MattChau01 for catching the error in the issue.
roslynwythe
left a comment
There was a problem hiding this comment.
Thank you @KyleA99 for your work on this issue. The code change is clean and correct and checks out in the browser. The PR is well-formed and descriptive. Thank you also for being responsive to the correction in the issue.
|
Special thanks to @ajb176 and @MattChau01 for a superb job testing and reviewing this issue |
MattChau01
left a comment
There was a problem hiding this comment.
Code change looks like it was properly adjusted ✅
Great work @KyleA99 for actively working on this issue!

Fixes #5505
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)