Skip to content

Add github-handle variable in _projects/100-automations.md#5565

Merged
kwangric merged 4 commits intohackforla:gh-pagesfrom
KyleA99:add-new-variable-github-5505
Sep 29, 2023
Merged

Add github-handle variable in _projects/100-automations.md#5565
kwangric merged 4 commits intohackforla:gh-pagesfrom
KyleA99:add-new-variable-github-5505

Conversation

@KyleA99
Copy link
Member

@KyleA99 KyleA99 commented Sep 21, 2023

Fixes #5505

What changes did you make?

  • Added "github-handle" variable to Camila Arias in _projects/100-automations.md

Why did you make the changes (we will use this info to test)?

  • This change was to help remove redundancy in website codebase. Redundant variables will be subsequently removed.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b KyleA99-add-new-variable-github-5505 gh-pages
git pull https://github.com/KyleA99/website.git add-new-variable-github-5505

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 21, 2023
@MattChau01 MattChau01 self-requested a review September 23, 2023 04:15
@MattChau01
Copy link
Member

Availability: Evening Saturday, most of the day Sunday
ETA: End of day Sunday

@roslynwythe roslynwythe self-requested a review September 24, 2023 17:17
MattChau01
MattChau01 previously approved these changes Sep 24, 2023
Copy link
Member

@MattChau01 MattChau01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The branch is going into the correct branch gh-pages. ✅
  • The original issue #5505 was properly referenced. ✅
  • The specified line of code was properly added on line 16. ✅

Great work @KyleA99!

@KyleA99
Copy link
Member Author

KyleA99 commented Sep 24, 2023

@MattChau01 @roslynwythe Should there be an actual github-handle value declared for this variable? Reviewing a similar PR right now and noticed that they added a value, whereas, my issue left it blank. Just wanted to confirm this was intentional.

@MattChau01
Copy link
Member

MattChau01 commented Sep 25, 2023

Hi @KyleA99 ! Would you mind providing the reference number for the other PR you saw? It could be a different scenario for that other issue. But would like to hear @roslynwythe for advice as well!

@KyleA99
Copy link
Member Author

KyleA99 commented Sep 25, 2023

@MattChau01 Here is the issue #5509

And corresponding PR #5563

@MattChau01
Copy link
Member

Thanks @KyleA99 . I took a look at the code that was changed in PR #5563 , but I'm not sure where the author received the phrase superbunker from. I would advise that you ask the author for clarification on why that was included, since it doesn't appear to be on the original issue (#5509).

@KyleA99
Copy link
Member Author

KyleA99 commented Sep 25, 2023

@MattChau01 you're right, I mistakenly thought it was in the original issue. I'll reach out and update you once I hear back

@MattChau01
Copy link
Member

@KyleA99 No worries, glad to help out!

@ajb176 ajb176 self-requested a review September 25, 2023 15:39
@ajb176
Copy link
Member

ajb176 commented Sep 25, 2023

I'm seeing some unwanted visual changes, even though Kyle edited the markdown file as suggested. The box containing the person's data seems to split into two. Does this issue occur for anyone else?

After changes: Screenshot 2023-09-25 at 9 19 52 PM

@tonyvang first noticed this issue here in another issue of the same template, and their PR omitted the '-' before '- githhub-handle-' and kept it in line with 'role' and 'links'. Their PR didn't cause any visual changes, but it was slightly different from the instructions in the linked issue.

@roslynwythe could you let me know if you're able to see this issue when reviewing this PR, because if so the original template may need to be slightly changed.

@KyleA99
Copy link
Member Author

KyleA99 commented Sep 25, 2023

@ajb176 I can see that unwanted visual change as well. Somehow missed that when I created the PR. I will check if this issue is also present in the PR I reviewed.

@MattChau01 @roslynwythe

@roslynwythe
Copy link
Member

roslynwythe commented Sep 27, 2023

@MattChau01 @KyleA99 @ajb176 There is an error in the original issue and it will be updated shortly. In the meantime please do not review or merge. Thank you

Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KyleA99 Please see the updated issue and my comment in the issue. I apologize for the error and want to thank @ajb176 @MattChau01 for catching the error in the issue.

Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @KyleA99 for your work on this issue. The code change is clean and correct and checks out in the browser. The PR is well-formed and descriptive. Thank you also for being responsive to the correction in the issue.

@roslynwythe
Copy link
Member

roslynwythe commented Sep 28, 2023

Special thanks to @ajb176 and @MattChau01 for a superb job testing and reviewing this issue

Copy link
Member

@MattChau01 MattChau01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks like it was properly adjusted ✅

Great work @KyleA99 for actively working on this issue!

@kwangric kwangric merged commit 11a4fcf into hackforla:gh-pages Sep 29, 2023
@KyleA99 KyleA99 deleted the add-new-variable-github-5505 branch October 3, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new variable github-handle for member Camila Arias in 100-automations.md

5 participants