Add github-handle variable#6099
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL: |
|
Availability: Evenings |
|
@jlevot thanks for taking up the issue, well the changes made by you are good to be merged, but before that I request some minor things
Ping me when you are done and I'll approve it |
|
@freaky4wrld Thank you for your review. I have updated the PR body and checkoff the box linked in the original issue. |
freaky4wrld
left a comment
There was a problem hiding this comment.
Everything looks to merge, branches are correct, changes made are seen in local environment.... PR approved!!
|
Availability: Evening 1/15 |
kwangric
left a comment
There was a problem hiding this comment.
Branches are set up correctly. The PR is linked to the correct issue and the requested changes to the 100.automations.md file has been made. Everything still looks good in Docker, and the PR includes why the changes were made. Great work!
Fixes #5504
What changes did you make?
Add an empty github handle variable on 100 Automations project for Niven Prasad
Why did you make the changes (we will use this info to test)?
Eventually github-handle will replace the github and picture variables, reducing redundancy in the project file.
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes