Skip to content

Add new variable github-handle to member Karen Coronel in ballot-nav.md#6357

Closed
aidenjlee4321 wants to merge 3 commits intohackforla:gh-pagesfrom
aidenjlee4321:gh-pages
Closed

Add new variable github-handle to member Karen Coronel in ballot-nav.md#6357
aidenjlee4321 wants to merge 3 commits intohackforla:gh-pagesfrom
aidenjlee4321:gh-pages

Conversation

@aidenjlee4321
Copy link
Contributor

Fixes #6234

What changes did you make?

Added github-handle variable to Karen Coronel in ballot-nav.md

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b aidenjlee4321-gh-pages gh-pages
git pull https://github.com/aidenjlee4321/website.git gh-pages

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/aidenjlee4321/website/blob/gh-pages/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 22, 2024
@ramitaarora ramitaarora self-requested a review February 22, 2024 18:22
@ramitaarora
Copy link
Member

Review ETA: Fri Feb 23 EoD
Availability: 9am-12pm Weekdays

@heejung-hong heejung-hong self-requested a review February 22, 2024 19:49
Copy link
Member

@heejung-hong heejung-hong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aidenjlee4321,

Can you kindly edit your comment and add information for the following:

  • Why did you make the changes (we will use this info to test)?
  • Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
    • If there are no visual changes, please indicate that in writing.

Please refer to the link for reference. #6099
I will approve your pull request once the changes have been made.

Thank you

@jphamtv
Copy link
Member

jphamtv commented Feb 23, 2024

Hey @aidenjlee4321 - Your pull request was made from your main branch, not an issue branch. I'm closing this PR as it's not from the correct branch.

Please create a new branch for your changes and open a new pull request. Refer to the Working on an issue section in the Contributing guide, particularly step 2.7.b, for how to create a new branch for your issue.

Also, @heejung-hong has provided additional feedback. Following the How to make a pull request section of the guide will help you submit a pull request that follows the organization's best practices, ensuring quicker approval. If you have any questions, don't hesitate to reach out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new variable github-handle to member Karen Coronel in ballot-nav.md

4 participants