Github Action that handles self assigning an issue from New Issue Approval column#6502
Github Action that handles self assigning an issue from New Issue Approval column#6502t-will-gillis merged 4 commits intohackforla:gh-pagesfrom marioantonini:gha-unassign-from-new-issue-approval-column-4821
New Issue Approval column#6502Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL: |
|
eta: 3/24 eod |
t-will-gillis
left a comment
There was a problem hiding this comment.
Hi @marioantonini - thanks for working on this issue. I tested this for assigning an issue from "New Issue Approval" and can confirm that with the Draft label the standard comment is posted, but when the Draft label is missing, the alternate comment is posted and the assignee is un-assigned. Also confirmed that the standard message is posted when issue is self-assigned from other columns per the original issue.
This is outside of the scope of the issue, but feel free to delete the console.log() on line 45 (since as written it doesn't provide any useful info), and you can decide about line 1...
|
Give me a couple of hours to do those changes. Will update after I'm done. |
|
Changes done, ready for review! |
t-will-gillis
left a comment
There was a problem hiding this comment.
Hey @marioantonini Awesome- thanks for removing the log statement and cleaning up the formatting / adding the explicit semicolons.
Since you are adding the semicolons- line 97?
|
@t-will-gillis That was a slip. Was debating on changing |
|
I am hesitant also. I would be OK with leaving them as |
t-will-gillis
left a comment
There was a problem hiding this comment.
Great thanks for all of the tweaks!
…proval` column (hackforla#6502) * Updated text to add to comment * Minor fix on markdown file and unassign contributor on js file * Cleaned up a little bit * A bit more cleanup --------- Co-authored-by: Mario Antonini <marioantonini@Marios-MacBook-Pro.local>
Fixes #4821
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
All changes made have no impact on appearance.