Skip to content

Github Action that handles self assigning an issue from New Issue Approval column#6502

Merged
t-will-gillis merged 4 commits intohackforla:gh-pagesfrom
marioantonini:gha-unassign-from-new-issue-approval-column-4821
Mar 24, 2024
Merged

Github Action that handles self assigning an issue from New Issue Approval column#6502
t-will-gillis merged 4 commits intohackforla:gh-pagesfrom
marioantonini:gha-unassign-from-new-issue-approval-column-4821

Conversation

@marioantonini
Copy link
Member

Fixes #4821

What changes did you make?

  • Added the markdown file used for the comment
  • Modified the action script to look for draft label and issue's card column in project board
  • Create a comment accordingly and remove the self assigned contributor

Why did you make the changes (we will use this info to test)?

  • Automate processes

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

All changes made have no impact on appearance.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b marioantonini-gha-unassign-from-new-issue-approval-column-4821 gh-pages
git pull https://github.com/marioantonini/HfLA_website.git gha-unassign-from-new-issue-approval-column-4821

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/marioantonini/website/blob/gha-unassign-from-new-issue-approval-column-4821/CONTRIBUTING.md  

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Large Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly size: 5pt Can be done in 19-30 hours labels Mar 21, 2024
@t-will-gillis t-will-gillis self-requested a review March 23, 2024 19:00
@t-will-gillis
Copy link
Member

eta: 3/24 eod

t-will-gillis
t-will-gillis previously approved these changes Mar 24, 2024
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @marioantonini - thanks for working on this issue. I tested this for assigning an issue from "New Issue Approval" and can confirm that with the Draft label the standard comment is posted, but when the Draft label is missing, the alternate comment is posted and the assignee is un-assigned. Also confirmed that the standard message is posted when issue is self-assigned from other columns per the original issue.

This is outside of the scope of the issue, but feel free to delete the console.log() on line 45 (since as written it doesn't provide any useful info), and you can decide about line 1...

@marioantonini
Copy link
Member Author

Give me a couple of hours to do those changes. Will update after I'm done.

@marioantonini
Copy link
Member Author

Changes done, ready for review!

t-will-gillis
t-will-gillis previously approved these changes Mar 24, 2024
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @marioantonini Awesome- thanks for removing the log statement and cleaning up the formatting / adding the explicit semicolons.

Since you are adding the semicolons- line 97?

@marioantonini
Copy link
Member Author

marioantonini commented Mar 24, 2024

@t-will-gillis That was a slip. Was debating on changing var github and var context (lines 7, 8) to const as well, but was hesitant. Any thoughts?

@t-will-gillis
Copy link
Member

I am hesitant also. I would be OK with leaving them as var. We declare them as var in similar functions, which itself is not a great argument but it is consistent...

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks for all of the tweaks!

@t-will-gillis t-will-gillis merged commit 4d0637b into hackforla:gh-pages Mar 24, 2024
@marioantonini marioantonini deleted the gha-unassign-from-new-issue-approval-column-4821 branch March 25, 2024 00:03
freaky4wrld pushed a commit to freaky4wrld/website that referenced this pull request Apr 9, 2024
…proval` column (hackforla#6502)

* Updated text to add to comment

* Minor fix on markdown file and unassign contributor on js file

* Cleaned up a little bit

* A bit more cleanup

---------

Co-authored-by: Mario Antonini <marioantonini@Marios-MacBook-Pro.local>
@t-will-gillis t-will-gillis mentioned this pull request Apr 16, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Large Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: back end/devOps Tasks for back-end developers size: 5pt Can be done in 19-30 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create GitHub Action to unassign devs from issues self-assigned from New Issue Approval column

2 participants