Skip to content

Bug fix- Devs should not be unassigned from their own Pre-work Checklist #6556

Closed
t-will-gillis wants to merge 3 commits intohackforla:gh-pagesfrom
t-will-gillis:fix-unassigning-preworks-6555
Closed

Bug fix- Devs should not be unassigned from their own Pre-work Checklist #6556
t-will-gillis wants to merge 3 commits intohackforla:gh-pagesfrom
t-will-gillis:fix-unassigning-preworks-6555

Conversation

@t-will-gillis
Copy link
Member

Fixes #6555

What changes did you make?

  • Changed check for whether Draft label is present, to instead check whether either [Draft, Complexity: Prework] are present
  • Edited message to note that "Pre-work Checklist"s are excluded- that is, OK for a dev to self-assign to their "Pre-work Checklist" from "New Issue Approval"

Why did you make the changes (we will use this info to test)?

  • To exclude "Pre-work Checklist"s from this action

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • Self repo #580 showing the message and unassigning except for when Draft or Complexity: Prework on issue.

@github-actions
Copy link

github-actions bot commented Apr 2, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b t-will-gillis-fix-unassigning-preworks-6555 gh-pages
git pull https://github.com/t-will-gillis/website.git fix-unassigning-preworks-6555

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/t-will-gillis/website/blob/fix-unassigning-preworks-6555/CONTRIBUTING.md  

@t-will-gillis t-will-gillis requested a review from jphamtv April 2, 2024 04:51
@github-actions github-actions bot added Bug Something isn't working role: back end/devOps Tasks for back-end developers time sensitive Needs to be worked on by a particular timeframe Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 1pt Can be done in 4-6 hours labels Apr 2, 2024
@jphamtv
Copy link
Member

jphamtv commented Apr 2, 2024

@t-will-gillis: Should we adjust the exception to avoid unassigning when the user is the issue creator or was assigned by someone else? This would handle cases where the Draft label is forgotten or not needed, and when Bonnie or merge team assign someone to an ER they forgot to self-assign.

@t-will-gillis
Copy link
Member Author

t-will-gillis commented Apr 2, 2024

Hey @jphamtv I messaged you also. I do think those are good questions. I wonder if the solution for right now should be to revert #6502 and have a team meeting to determine exactly what this action should do?

@jphamtv
Copy link
Member

jphamtv commented Apr 2, 2024

Hey @jphamtv I messaged you also. I do think those are good questions. I wonder if the solution for right now should be to revert #6502 and have a team meeting to determine exactly what this action should do?

Yeah that sounds like a good solution for now until we can discuss at the next meeting.

@t-will-gillis
Copy link
Member Author

Closing the PR temporarily and replacing with #6557 which reverts the previous PR #6502 so that we can discuss in a team meeting what the final action should do, what exclusions we need, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours time sensitive Needs to be worked on by a particular timeframe

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug fix! Issues labeled Complexity: Prework in "New Issue Approval" should not unassign devs who self-assign

2 participants