Skip to content

Issue #6236: Add github-handle to Layne Mostyn in ballot-nav#6546

Merged
roslynwythe merged 1 commit intohackforla:gh-pagesfrom
jonnyoe:new-var-gh-6236
Mar 29, 2024
Merged

Issue #6236: Add github-handle to Layne Mostyn in ballot-nav#6546
roslynwythe merged 1 commit intohackforla:gh-pagesfrom
jonnyoe:new-var-gh-6236

Conversation

@jonnyoe
Copy link
Member

@jonnyoe jonnyoe commented Mar 29, 2024

Fixes #6236

What changes did you make?

  • Added the new gh-handle variable under Layne Mostyn in ballot-nav.md

Why did you make the changes (we will use this info to test)?

  • Creates a single variable github-handle to hold the github handle for each member of the leadership team. Reduces redundancy by progressively replacing the github and picture variables in the project file.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • No Visual changes (Confirmed via docker)

@jonnyoe jonnyoe requested a review from JackCasica March 29, 2024 04:23
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jonnyoe-new-var-gh-6236 gh-pages
git pull https://github.com/jonnyoe/website.git new-var-gh-6236

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/jonnyoe/website/blob/new-var-gh-6236/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Mar 29, 2024
Copy link
Member

@JackCasica JackCasica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Evan,

Thank you for the work you've put into this pull request and taking time to tidy up the commit history as we discussed in the previous PR thread (#6535) ✅

I see that you successfully added the new github-handle variable for Layne Mostyn, which was the main goal of this issue (#6236). Nice work!

PR approved ~

Copy link
Member

@jphamtv jphamtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jonnyoe - Thanks for working on this issue.

  • The pull request is done with the correct branch
  • The issue is properly linked
  • Your code change is clean, accurate, and correctly uses spaces instead of tab

Minor feedback on summary of changes: you mentioned adding 'gh-handle' variable instead of 'github-handle'.

Overall nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new variable github-handle to member Layne Mostyn in ballot-nav.md

4 participants