Skip to content

Issue #6236: Add github-handle to Layne Mostyn in ballot-nav#6535

Closed
jonnyoe wants to merge 5 commits intohackforla:gh-pagesfrom
jonnyoe:new-var-gh-handle-6236
Closed

Issue #6236: Add github-handle to Layne Mostyn in ballot-nav#6535
jonnyoe wants to merge 5 commits intohackforla:gh-pagesfrom
jonnyoe:new-var-gh-handle-6236

Conversation

@jonnyoe
Copy link
Member

@jonnyoe jonnyoe commented Mar 27, 2024

Fixes #6236

What changes did you make?

  • Added the new gh-handle variable under Layne Mostyn in ballot-nav.md

Why did you make the changes (we will use this info to test)?

  • Creates a single variable github-handle to hold the github handle for each member of the leadership team. Reduces redundancy by progressively replacing the github and picture variables in the project file.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • No Visual changes (Confirmed via docker)

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jono4727-new-var-gh-handle-6236 gh-pages
git pull https://github.com/jono4727/website.git new-var-gh-handle-6236

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/jono4727/website/blob/new-var-gh-handle-6236/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Mar 27, 2024
@jonnyoe jonnyoe changed the title New var gh handle 6236 Issue #6236: Add github-handle to Layne Mostyn in ballot-nav Mar 27, 2024
@JackCasica JackCasica self-requested a review March 28, 2024 14:37
@JackCasica
Copy link
Member

Hi ~ I'll be reviewing this PR today ~
Availability: (03/28)
ETA: EOD (03/28)

Copy link
Member

@JackCasica JackCasica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Evan,

Thank you for the work you've put into this pull request! Here's what's great and what could be improved:

✅ What's Great:

You successfully added the new github-handle variable for Layne Mostyn, which was the main goal of this issue. Nice work!

🔍 Areas for Improvement:

The commit history in this PR includes 5 commits, but only one seems directly related to the issue at hand (#6536). The other 4 commits appear to be changes from earlier dates that have already been merged. In an effort to make the commit history as clear as possible, it may be best to create a new PR that includes just the most recent commit (sha 43a88d8).

Feel free to let me know if you have any questions or if you want to work through it on a video call together.

@jonnyoe
Copy link
Member Author

jonnyoe commented Mar 28, 2024

Closing this PR to create a clean one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new variable github-handle to member Layne Mostyn in ballot-nav.md

2 participants