Skip to content

Added logic to an Issue's preliminary comment with accompanying messages#6811

Merged
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
marioantonini:complexity-prework-self-assign-6555
May 3, 2024
Merged

Added logic to an Issue's preliminary comment with accompanying messages#6811
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
marioantonini:complexity-prework-self-assign-6555

Conversation

@marioantonini
Copy link
Member

Fixes #6555

What changes did you make?

  • Updated the js file to determine which comment template to use based on multiple checks.
  • Created 2 markdown files to support the changes in the scripting.

Why did you make the changes (we will use this info to test)?

  • To make it easier to understand for people self assigning issues that they should not, or that they should label properly.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

NA

@github-actions
Copy link

github-actions bot commented May 3, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b marioantonini-complexity-prework-self-assign-6555 gh-pages
git pull https://github.com/marioantonini/HfLA_website.git complexity-prework-self-assign-6555

@github-actions github-actions bot added Bug Something isn't working role: back end/devOps Tasks for back-end developers time sensitive Needs to be worked on by a particular timeframe status: Updated No blockers and update is ready for review Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 1pt Can be done in 4-6 hours labels May 3, 2024
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @marioantonini Fantastic work. From testing on my repo, everything appears to be working as intended:

  • Author matches assignee, no Draft: message reminder to add Draft
  • Author matches assignee, w/ Draft: typical message posted
  • Author doesn't match assignee, w/ Draft: typical message posted
  • Author doesn't match assignee, no Draft or Prework: assignee is un-assigned w/ message
  • Issue is labelled Complexity: Prework: typical message posted

Thanks once again for your changes and for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours status: Updated No blockers and update is ready for review time sensitive Needs to be worked on by a particular timeframe

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug fix! Issues labeled Complexity: Prework in "New Issue Approval" should not unassign devs who self-assign

2 participants