Add github-handle for Selena Jiang in ems-triage-tracker.md#6898
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
There was a problem hiding this comment.
Review ETA: 11 AM 5/26/24
This looks great! Besides the formatting issues presented by @t-will-gillis, you followed the items on the checklist and followed the protocol for submitting a PR.
- Branching done correctly
- Issue included
- Used spaces and correctly added the
github-handleproperty - Proper naming of the issue
Congrats on the PR! Thank you for the contribution.
t-will-gillis
left a comment
There was a problem hiding this comment.
Hey @dcotelessa Congrats on your first HfLA PR-
- Branches 'from' and 'into' are correct
- Original issue is linked
- A brief description of what was done and why is provided
- The code edit is clean
Some notes:
- Under the 'what change' and 'why', please remove the extra lines
- Under 'Screenshots of Proposed Changes..." please remove everything and replace with something to the effect of "No visual changes to website"
Thanks for working on this!
|
Hi @mrodz Here is an example of a well-done review: #6887 (review) When we look at this, we can see both that the reviewer has done a thorough job checking the PR, and the reviewee has done their job in creating the PR. |
Thank you for the help! I am new to reviewing PR's and I appreciate the feedback. I will use your tips for the next PR's I review. |
|
Great feedback. I will keep the format in mind for readability. Thanks! |
t-will-gillis
left a comment
There was a problem hiding this comment.
Hey @dcotelessa - Perfect, thanks for making the edits. Everything looks great!
mrodz
left a comment
There was a problem hiding this comment.
I am re-approving this PR as the formatting was fixed. Good work!
Fixes #6723
What changes did you make?
github-handle:under- name: Selena JiangWhy did you make the changes (we will use this info to test)?
No visual changes to website.