Update Alt Text for Page Card Icon Image#6887
Merged
LRenDO merged 1 commit intohackforla:gh-pagesfrom May 29, 2024
Merged
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
Member
|
Review ETA: 11 PM 5/23/24 |
Member
|
Review ETA: 11:59 PM 5/26/24 |
del9ra
approved these changes
May 24, 2024
Member
del9ra
left a comment
There was a problem hiding this comment.
Hi @jenjenkayi,
- The branching was done correctly
- the Issue number was listed
- alt="" in code while show up as alt when using developer tools
- SiteMap page stays the same after the change
- The PR title is descriptive of the changes
- The PR request clearly states what and why was updated
Thank you! Great job!
This was referenced May 27, 2024
aidanwsimmons
approved these changes
May 29, 2024
Member
aidanwsimmons
left a comment
There was a problem hiding this comment.
hey @jenjenkayi
- branches look good
- issue linked
- clear descriptions for changes
- changes appropriately address the issues action item
Nice job- Approved!
7 tasks
This was referenced Aug 10, 2025
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6800
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)