Skip to content

Update Alt Text for Page Card Icon Image#6887

Merged
LRenDO merged 1 commit intohackforla:gh-pagesfrom
jenjenkayi:update-alt-text-6800
May 29, 2024
Merged

Update Alt Text for Page Card Icon Image#6887
LRenDO merged 1 commit intohackforla:gh-pagesfrom
jenjenkayi:update-alt-text-6800

Conversation

@jenjenkayi
Copy link
Member

Fixes #6800

What changes did you make?

  • added alt text for page card icon image.

Why did you make the changes (we will use this info to test)?

  • provide clear and descriptive alt text on the SiteMap page so that we adhere to the Web Content Accessibility Guidelines (WCAG).

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • added alt text. No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b jenjenkayi-update-alt-text-6800 gh-pages
git pull https://github.com/jenjenkayi/website.git update-alt-text-6800

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Accessibility Issues that would broaden website accessibility size: 1pt Can be done in 4-6 hours labels May 22, 2024
@del9ra del9ra self-assigned this May 24, 2024
@del9ra del9ra self-requested a review May 24, 2024 02:01
@del9ra del9ra removed their assignment May 24, 2024
@del9ra
Copy link
Member

del9ra commented May 24, 2024

Review ETA: 11 PM 5/23/24
Availability: 1-4 PM Friday

@smendoza07 smendoza07 self-requested a review May 24, 2024 02:21
@smendoza07
Copy link
Member

Review ETA: 11:59 PM 5/26/24
Availability: 7-9 PM Saturday-Sunday

Copy link
Member

@del9ra del9ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jenjenkayi,

  • The branching was done correctly
  • the Issue number was listed
  • alt="" in code while show up as alt when using developer tools 
  • SiteMap page stays the same after the change
  • The PR title is descriptive of the changes
  • The PR request clearly states what and why was updated
    Thank you! Great job!

Copy link
Member

@aidanwsimmons aidanwsimmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jenjenkayi

  • branches look good
  • issue linked
  • clear descriptions for changes
  • changes appropriately address the issues action item
    Nice job- Approved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Accessibility Issues that would broaden website accessibility good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SiteMap Page: Update alt text for Page Card Icon image to adhere to WCAG

5 participants