Skip to content

Add github handle field#6901

Merged
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
jazxbx:add-github-handle-6733
Jun 2, 2024
Merged

Add github handle field#6901
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
jazxbx:add-github-handle-6733

Conversation

@jazxbx
Copy link
Member

@jazxbx jazxbx commented May 27, 2024

Fixes #6733

What changes did you make?

-Add github handle field to John Darragh's entry

Why did you make the changes (we will use this info to test)?

-This variable will eventually replace github and picture variables to reduce redundancy in the project file.

No visual changes to the website.

@jazxbx jazxbx requested a review from 93Belen May 27, 2024 18:50
@jazxbx jazxbx self-assigned this May 27, 2024
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b jazxbx-add-github-handle-6733 gh-pages
git pull https://github.com/jazxbx/website.git add-github-handle-6733

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels May 27, 2024
@terrencejihoonjung
Copy link
Member

Review ETA: 11:59PM (PST) 5/29/24
Availability: 10AM-10PM (Mon-Fri)

@LRenDO
Copy link
Member

LRenDO commented May 29, 2024

Hi @ino-iosdev! Thanks for volunteering to review this issue! When you have a minute, please add your ETA and Availability.

@LRenDO
Copy link
Member

LRenDO commented May 29, 2024

Hi @jazxbx! Thanks for working on this issue! With regards to reviewers, unless we have had a conversation with someone and they agree to review a particular PR, we don't generally don't add other people as reviewers. If you had a conversation like that with @93Belen, great! Otherwise, please go ahead and remove them as reviewer. Thanks!

@ino-iosdev
Copy link
Member

Review ETA: 6 PM 5/29
Availability: Flexible except for Wedn. afternoon till end of June.

@jazxbx jazxbx removed the request for review from 93Belen May 29, 2024 20:27
@jazxbx
Copy link
Member Author

jazxbx commented May 29, 2024

@LRenDO Ahh I see! Thanks so much for clearing that up. I removed Belen!

@jazxbx
Copy link
Member Author

jazxbx commented May 29, 2024

Review ETA: 11:59PM (PST) 5/29/24 Availability: 10AM-10PM (Mon-Fri)

Hi @terrencejihoonjung thanks for your time! Do you want me to be around when doing the review? I didnt see any documentation regarding reviews. I'm available today from 6PM - 10PM. Thanks again

Copy link
Member

@ino-iosdev ino-iosdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jazxbx , It's such a blessing to have you as part of the team here!

  • Naming was appropriate
  • Direction between branches "from" and "to" are clear
  • The changes and why were clear
  • PR issue link was clear
  • No visual changes to the website

Great job, thank you for contributing!

Copy link
Member

@terrencejihoonjung terrencejihoonjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jazxbx, great work!

  • the branching was done correctly
  • the Issue number was listed/linked
  • the "github-handle" variable was properly added
  • project webpage remains unchanged at all screen sizes

Changes Requested:

  • make sure to state why you made the changes in your PR. This will be important for future PRs that have greater complexity! However, your PR title and statement of changes done are clear and direct.

In regards to your comment #6901 (comment), you are good! PR reviews are usually done asynchronously at the reviewer's convenience. Once approved, you are good to move on to the next issue~

Here are some links for your reference:

Thank you!

@jazxbx
Copy link
Member Author

jazxbx commented May 30, 2024

Hi @jazxbx , It's such a blessing to have you as part of the team here!

  • Naming was appropriate
  • Direction between branches "from" and "to" are clear
  • The changes and why were clear
  • PR issue link was clear
  • No visual changes to the website

Great job, thank you for contributing!

Thanks so much! Excited to work with everyone!🙌

@jazxbx
Copy link
Member Author

jazxbx commented May 30, 2024

@terrencejihoonjung Added the requested change! Thanks for the references as well!

@ino-iosdev ino-iosdev linked an issue May 30, 2024 that may be closed by this pull request
5 tasks
@LRenDO
Copy link
Member

LRenDO commented May 30, 2024

@LRenDO Ahh I see! Thanks so much for clearing that up. I removed Belen!

Perfect! Thanks!

@del9ra del9ra self-requested a review May 30, 2024 17:41
@jphamtv
Copy link
Member

jphamtv commented May 30, 2024

Hey @jazxbx, make sure to re-request reviews from the original reviewer after you have made the requested changes by clicking on the circular arrows icon next to their names. I have done this for you so this is just for future reference. Thanks!
Screenshot 2024-05-30 at 10 59 55

@del9ra
Copy link
Member

del9ra commented May 30, 2024

Review ETA: 05/31/2024
Availability: 1-5 PM Friday

Copy link
Member

@del9ra del9ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jazxbx ,

  • The pull request is done with the correct branch
  • Can you please remove this issue #6730 from the Development section. This is the correct issue #6733
  • Please check off the Action Items when working on issues to indicate you have completed them.
  • The PR clearly tells us what changes were made and why
  • I will be happy to approve it after the changes are implemented.
    Nice work! Well done!

@jazxbx
Copy link
Member Author

jazxbx commented May 31, 2024

Hey @jazxbx, make sure to re-request reviews from the original reviewer after you have made the requested changes by clicking on the circular arrows icon next to their names. I have done this for you so this is just for future reference. Thanks! Screenshot 2024-05-30 at 10 59 55

Thanks so much!

@jazxbx
Copy link
Member Author

jazxbx commented May 31, 2024

Hey @jazxbx ,

Done! 🙌

@jazxbx jazxbx requested a review from del9ra May 31, 2024 05:31
@del9ra
Copy link
Member

del9ra commented May 31, 2024

@jazxbx you forgot to check off the Action Items on the issue page. Please do this, and I'll approve.

@jazxbx
Copy link
Member Author

jazxbx commented Jun 1, 2024

@jazxbx you forgot to check off the Action Items on the issue page. Please do this, and I'll approve.

Hey just making sure I'm getting this. Did you want me to check this off?
Once the pr is approved, this should automatically close the issue.
image

Copy link
Member

@terrencejihoonjung terrencejihoonjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jazxbx! Thanks, looks great! I also would note that you should check off your finished tasks within the issue #6733. I see that @del9ra has requested this change, so I'll leave the request for that change to theirs!

Good work!

@del9ra
Copy link
Member

del9ra commented Jun 1, 2024

@jazxbx you forgot to check off the Action Items on the issue page. Please do this, and I'll approve.

Hey just making sure I'm getting this. Did you want me to check this off? Once the pr is approved, this should automatically close the issue. image

Mark up action items on this page #6733

@jazxbx
Copy link
Member Author

jazxbx commented Jun 1, 2024

@jazxbx you forgot to check off the Action Items on the issue page. Please do this, and I'll approve.

Hey just making sure I'm getting this. Did you want me to check this off? Once the pr is approved, this should automatically close the issue. image

Mark up action items on this page #6733

Ohh thanks for the clarification! Marked as done!

@ino-iosdev
Copy link
Member

@jazxbx you forgot to check off the Action Items on the issue page. Please do this, and I'll approve.

Hey just making sure I'm getting this. Did you want me to check this off? Once the pr is approved, this should automatically close the issue. image

Mark up action items on this page #6733

Ohh thanks for the clarification! Marked as done!

@jazxbx I just moved it back from project board aka undid your action on #6733 because I believe what they are saying is to check off the tasks here:

Screenshot 2024-06-01 at 9 21 00 PM

@jazxbx
Copy link
Member Author

jazxbx commented Jun 2, 2024

@jazxbx you forgot to check off the Action Items on the issue page. Please do this, and I'll approve.

Hey just making sure I'm getting this. Did you want me to check this off? Once the pr is approved, this should automatically close the issue. image

Mark up action items on this page #6733

Ohh thanks for the clarification! Marked as done!

@jazxbx I just moved it back from project board aka undid your action on #6733 because I believe what they are saying is to check off the tasks here:

Screenshot 2024-06-01 at 9 21 00 PM

Ahhh I see.. Mb ✌️Marked. Thanks for the images 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add github-handle for John Darragh in food-oasis.md

7 participants