Add github handle field#6901
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 11:59PM (PST) 5/29/24 |
|
Hi @ino-iosdev! Thanks for volunteering to review this issue! When you have a minute, please add your ETA and Availability. |
|
Hi @jazxbx! Thanks for working on this issue! With regards to reviewers, unless we have had a conversation with someone and they agree to review a particular PR, we don't generally don't add other people as reviewers. If you had a conversation like that with @93Belen, great! Otherwise, please go ahead and remove them as reviewer. Thanks! |
|
Review ETA: 6 PM 5/29 |
|
@LRenDO Ahh I see! Thanks so much for clearing that up. I removed Belen! |
Hi @terrencejihoonjung thanks for your time! Do you want me to be around when doing the review? I didnt see any documentation regarding reviews. I'm available today from 6PM - 10PM. Thanks again |
ino-iosdev
left a comment
There was a problem hiding this comment.
Hi @jazxbx , It's such a blessing to have you as part of the team here!
- Naming was appropriate
- Direction between branches "from" and "to" are clear
- The changes and why were clear
- PR issue link was clear
- No visual changes to the website
Great job, thank you for contributing!
There was a problem hiding this comment.
Hi @jazxbx, great work!
- the branching was done correctly
- the Issue number was listed/linked
- the "github-handle" variable was properly added
- project webpage remains unchanged at all screen sizes
Changes Requested:
- make sure to state why you made the changes in your PR. This will be important for future PRs that have greater complexity! However, your PR title and statement of changes done are clear and direct.
In regards to your comment #6901 (comment), you are good! PR reviews are usually done asynchronously at the reviewer's convenience. Once approved, you are good to move on to the next issue~
Here are some links for your reference:
- How to Review Pull Requests: https://github.com/hackforla/website/wiki/How-to-Review-Pull-Requests#Feedback
- Good Example of a Review/Approval: #6887 (review)
- Making Pull Requests: https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md#part-3-pull-requests
Thank you!
Thanks so much! Excited to work with everyone!🙌 |
|
@terrencejihoonjung Added the requested change! Thanks for the references as well! |
Perfect! Thanks! |
|
Hey @jazxbx, make sure to re-request reviews from the original reviewer after you have made the requested changes by clicking on the circular arrows icon next to their names. I have done this for you so this is just for future reference. Thanks! |
|
Review ETA: 05/31/2024 |
del9ra
left a comment
There was a problem hiding this comment.
Hey @jazxbx ,
- The pull request is done with the correct branch
- Can you please remove this issue #6730 from the Development section. This is the correct issue #6733
- Please check off the Action Items when working on issues to indicate you have completed them.
- The PR clearly tells us what changes were made and why
- I will be happy to approve it after the changes are implemented.
Nice work! Well done!
Thanks so much! |
Done! 🙌 |
|
@jazxbx you forgot to check off the Action Items on the issue page. Please do this, and I'll approve. |
Hey just making sure I'm getting this. Did you want me to check this off? |
Ohh thanks for the clarification! Marked as done! |
@jazxbx I just moved it back from project board aka undid your action on #6733 because I believe what they are saying is to check off the tasks here:
|
Ahhh I see.. Mb ✌️Marked. Thanks for the images 😭 |






Fixes #6733
What changes did you make?
-Add github handle field to John Darragh's entry
Why did you make the changes (we will use this info to test)?
-This variable will eventually replace github and picture variables to reduce redundancy in the project file.
No visual changes to the website.