Skip to content

Added github handle for Bonnie Wolfe in tdm-calculator.md#7235

Merged
jphamtv merged 1 commit intohackforla:gh-pagesfrom
hkhaung:add-github-handle-7171
Aug 8, 2024
Merged

Added github handle for Bonnie Wolfe in tdm-calculator.md#7235
jphamtv merged 1 commit intohackforla:gh-pagesfrom
hkhaung:add-github-handle-7171

Conversation

@hkhaung
Copy link
Member

@hkhaung hkhaung commented Aug 7, 2024

Fixes #7171

What changes did you make?

  • added github-handle in /_projects/tdm-calculator.md for Bonnie Wolfe

Why did you make the changes (we will use this info to test)?

  • to hold the github handle which will eventually replace the github and picture variables, reducing redundancy in the project file

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No screenshots since adding a variable did not create any new visual change

@github-actions
Copy link

github-actions bot commented Aug 7, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b hkhaung-add-github-handle-7171 gh-pages
git pull https://github.com/hkhaung/website.git add-github-handle-7171

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 7, 2024
@cchrizzle cchrizzle self-requested a review August 7, 2024 19:46
@cchrizzle
Copy link
Member

Hi @hkhaung, thank you for working on this!

The changes you've made look good:

  1. You linked to the original issue.
  2. You added the section of "github-handle" as requested.
  3. You used spaces to indent as requested as well.
  4. You specified that there are no screenshots.

Just a couple requests:

  1. Specify who you made the changes for in both the title and the description of changes you made section (Bonnie Wolfe in this case).
  2. Tie the reasoning for your changes into a bigger picture, higher level description of what the changes are meant to address. You can get this from the overview in the original issue, such as "reducing redundancy in the project file".
  3. Specify the reasoning that you don't have any screenshots (no visual changes).

Once you have those everything should be good to go!

@Anahisv23 Anahisv23 self-requested a review August 7, 2024 20:53
@Anahisv23
Copy link
Member

Availability: M - F 12pm - 5pm
ETA: EOD

@hkhaung hkhaung changed the title Added github handle in tdm-calculator.md Added github handle for Bonnie Wolfe in tdm-calculator.md Aug 7, 2024
@hkhaung
Copy link
Member Author

hkhaung commented Aug 7, 2024

Hi @cchrizzle, I've updated the title and description as per your feedback. Let me know if there is anything else needed. Thanks.

Copy link
Member

@Anahisv23 Anahisv23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hkhaung, thank you for working on this issue. Here's what you did well. Overall nice work!

What went well

  • Into and from branch are set up correctly
  • The linked issue links to the correct issue
  • Modified the appropriate lines of code to add the github-variable
  • Did not indent with tab
  • Fixed the PR itself to be more descriptive of the overall goal of the ticket

Copy link
Member

@cchrizzle cchrizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, approved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Bonnie Wolfe in tdm-calculator.md

4 participants