Added github-handle for Farah Khan in home-unite-us.md #7264
Added github-handle for Farah Khan in home-unite-us.md #7264codyyjxn wants to merge 14 commits intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: Weekdays 8am-8pm, Weekends 9am-5pm |
|
Availability: Sun/Mon all day, Tues-Fri evenings |
daras-cu
left a comment
There was a problem hiding this comment.
Hi @codyyjxn, thanks for working on this issue! A couple things to address:
- You added
github-handlecorrectly inhome-unite-us.md, but two additional files have changes that were not called for-CNAMEandREADME.md. Please take a look at these and revert the changes. - In your PR explanation, you should be more specific about the changes you made by including where or who you added the new variable for. This could be copied directly from the original issue or just note that it was for Farah Khan.
- Instead of deleting the whole screenshot section in the PR, I would keep it there and just note that there are no visual changes to the website to make it more clear for reviewers.
- It looks like you may have cut off part of the "Why did you make the changes" answer.
Otherwise your branches are set up correctly for merging and when I test the changes locally the Home Unite Us page displays as it should.
A good idea may be to review successfully merged PRs for similar issues to see what they should look like, for example #7325.
Once you've made the adjustments let me know in a comment or re-request a review and I'll come back to take a look.
daras-cu
left a comment
There was a problem hiding this comment.
Hi @codyyjxn, thanks for making the adjustments! Everything looks good except CNAME is still showing up under the changed files, I know both versions look the same but I think the difference may be a newline after www.hackforla.org. You can manually adjust this again or to be sure everything is the same you can do a git checkout of just the CNAME file from a branch where it is unchanged.
mrodz
left a comment
There was a problem hiding this comment.
Hi @codyyjxn, thanks for making the adjustments! Everything looks good except CNAME is still showing up under the changed files, I know both versions look the same but I think the difference may be a newline after
www.hackforla.org. You can manually adjust this again or to be sure everything is the same you can do a git checkout of just the CNAME file from a branch where it is unchanged.
Hi @codyyjxn, this article explains what a rebase is. I might try to rebase and remove the touches you made to the extra files if I were you.
If you get stuck, add the ready for dev lead label and move this issue from In progress (actively working) to Questions / In Review and explain your issue.
If rebasing is too complicated, I suggest you start over again as this issue is small and not worth a headache trying to learn some of git's complicated features if you're new to version control. For now, I am marking this as incomplete. Leave a comment and tag us when you have a fix :)
…website into add-github-handle-7185
|
Yea I am going to just start over with a new issue. |
|
@codyyjxn I don't think you have to start over with a whole new issue, what I would do is just delete the branch you have been working on (locally and on GitHub) and start over with the same issue on a new branch. You can close this pull request and once you have your changes done on the new branch just open a new PR. If you do prefer to start over with a new issue you can follow the steps here to unassign yourself from the current issue, and then you will be able to pick up a new one. Either way I would suggest that after you've made changes, only stage the specific file(s) included in the issue before you commit (you can |
|
Okay I will be working on it. Thanks ! @daras-cu |
Fixes #7185
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)