Skip to content

Added github-handle for Farah Khan in home-unite-us.md #7264

Closed
codyyjxn wants to merge 14 commits intohackforla:gh-pagesfrom
codyyjxn:add-github-handle-7185
Closed

Added github-handle for Farah Khan in home-unite-us.md #7264
codyyjxn wants to merge 14 commits intohackforla:gh-pagesfrom
codyyjxn:add-github-handle-7185

Conversation

@codyyjxn
Copy link
Member

@codyyjxn codyyjxn commented Aug 10, 2024

Fixes #7185

What changes did you make?

  • The github-handle for Farah Khan has been successfully added to the projects/home-unite-us.md file.

Why did you make the changes (we will use this info to test)?

  • Update related logic and documentation to reflect the use of the github handle variable, thereby ensuring consistent references throughout the project.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • No screenshots since adding a variable did not create any new visual change

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b codyyjxn-add-github-handle-7185 gh-pages
git pull https://github.com/codyyjxn/website.git add-github-handle-7185

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 10, 2024
@codyyjxn codyyjxn self-assigned this Aug 10, 2024
@mrodz
Copy link
Member

mrodz commented Aug 11, 2024

Availability: Weekdays 8am-8pm, Weekends 9am-5pm
ETA: EOD 8/11/24

@daras-cu
Copy link
Member

Availability: Sun/Mon all day, Tues-Fri evenings
ETA: 8/11 EOD

Copy link
Member

@daras-cu daras-cu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @codyyjxn, thanks for working on this issue! A couple things to address:

  • You added github-handle correctly in home-unite-us.md, but two additional files have changes that were not called for- CNAME and README.md. Please take a look at these and revert the changes.
  • In your PR explanation, you should be more specific about the changes you made by including where or who you added the new variable for. This could be copied directly from the original issue or just note that it was for Farah Khan.
  • Instead of deleting the whole screenshot section in the PR, I would keep it there and just note that there are no visual changes to the website to make it more clear for reviewers.
  • It looks like you may have cut off part of the "Why did you make the changes" answer.

Otherwise your branches are set up correctly for merging and when I test the changes locally the Home Unite Us page displays as it should.

A good idea may be to review successfully merged PRs for similar issues to see what they should look like, for example #7325.

Once you've made the adjustments let me know in a comment or re-request a review and I'll come back to take a look.

@codyyjxn codyyjxn changed the title Add GitHub handle 7185 Add github-handle for Farah Khan in home-unite-us.md Aug 12, 2024
@codyyjxn codyyjxn changed the title Add github-handle for Farah Khan in home-unite-us.md Added github-handle for Farah Khan in home-unite-us.md Aug 12, 2024
@codyyjxn codyyjxn requested a review from daras-cu August 13, 2024 01:35
Copy link
Member

@daras-cu daras-cu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @codyyjxn, thanks for making the adjustments! Everything looks good except CNAME is still showing up under the changed files, I know both versions look the same but I think the difference may be a newline after www.hackforla.org. You can manually adjust this again or to be sure everything is the same you can do a git checkout of just the CNAME file from a branch where it is unchanged.

Copy link
Member

@mrodz mrodz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @codyyjxn, thanks for making the adjustments! Everything looks good except CNAME is still showing up under the changed files, I know both versions look the same but I think the difference may be a newline after www.hackforla.org. You can manually adjust this again or to be sure everything is the same you can do a git checkout of just the CNAME file from a branch where it is unchanged.

Hi @codyyjxn, this article explains what a rebase is. I might try to rebase and remove the touches you made to the extra files if I were you.

If you get stuck, add the ready for dev lead label and move this issue from In progress (actively working) to Questions / In Review and explain your issue.

If rebasing is too complicated, I suggest you start over again as this issue is small and not worth a headache trying to learn some of git's complicated features if you're new to version control. For now, I am marking this as incomplete. Leave a comment and tag us when you have a fix :)

@codyyjxn
Copy link
Member Author

codyyjxn commented Aug 13, 2024

Yea I am going to just start over with a new issue.
When can I start a new issue ?

@codyyjxn codyyjxn added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Aug 13, 2024
@codyyjxn codyyjxn requested review from daras-cu and mrodz August 13, 2024 17:47
@daras-cu
Copy link
Member

@codyyjxn I don't think you have to start over with a whole new issue, what I would do is just delete the branch you have been working on (locally and on GitHub) and start over with the same issue on a new branch. You can close this pull request and once you have your changes done on the new branch just open a new PR.

If you do prefer to start over with a new issue you can follow the steps here to unassign yourself from the current issue, and then you will be able to pick up a new one.

Either way I would suggest that after you've made changes, only stage the specific file(s) included in the issue before you commit (you can git add a single file by specifying the file path, see here). This should avoid any unintentional changes to other files.

@codyyjxn
Copy link
Member Author

Okay I will be working on it. Thanks ! @daras-cu

@codyyjxn codyyjxn closed this Aug 19, 2024
@codyyjxn codyyjxn deleted the add-github-handle-7185 branch August 19, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) ready for dev lead Issues that tech leads or merge team members need to follow up on role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Farah Khan in home-unite-us.md

3 participants