Add github-handle for Tyler Thome in home-unite-us.md #7309
Add github-handle for Tyler Thome in home-unite-us.md #7309ihop-56 wants to merge 1 commit intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: EoD |
iancooperman
left a comment
There was a problem hiding this comment.
This largely looks good, but please add the issue number "7175" to the name of your branch in your fork.
|
Review ETA: EOD
|
8alpreet
left a comment
There was a problem hiding this comment.
Hi @ihop-56,
What went well:
- Into branch is set up correctly.
- PR is linked to the correct issue number.
- Only relevant lines of code were changed.
Changes needed:
- The issue number must be a part of the branch name. It works well as a suffix (in my opinion).
- The "what changes did you make" section:
- It has repeated sentences.
- It mentions visual changes which has a section of it's own thus does not need to be discussed in this section.
- It does not provide insight into the changes, rather it points the reader to the issue. Which is not an invalid approach; however, It would be helpful to reiterate the intention of the linked issue in your own words.
minkang3
left a comment
There was a problem hiding this comment.
File changes look good.
There is a slight formatting error in your PR where your second bullet point is not spaced properly. Add a space after "-" and it should be fixed.
|
Review ETA: 9am - 8pm 8/22/2024 |
codyyjxn
left a comment
There was a problem hiding this comment.
Hi @ihop-56
Things you did correctly:
- Branch is set up correctly.
- PR is linked to the correct issue number.
- Correct file change
Things you should change:
- In the "What changes did you make?" section, try to keep it concise and avoid repetition.
- Including the issue number in the branch name is a good practice. It helps others quickly identify the context, especially when viewing the branch for the first time.
|
Hi @ihop-56, The title was fine before. No need to add the issue number on the title. |
|
Hi @codyyjxn I've updated the branch name to Please let me know if there's anything else needed. Thank you! |
|
Hi @ihop-56, I looked it up and it's not possible to rename a branch when a PR is open. Technically, branches are not renamed on Github, they are deleted and replaced. I went onto your account and saw that you have created a new branch containing the issue number but it is not linked to this PR. You will have to open a new PR. Useful instructions for updating branch name: LINK |
|
Hi @ihop-5 -6 Thank you for updating the branch name. Since you have created a new PR from that new branch, you may want to close this one to avoid confusion. I will link the new one here for reference. #7346 |
Fixes #7175
What changes did you make?
github-handle:field undername: Tyler Thomein the_projects/home-unite-us.mdfile. This field was added without a value as per the issue's instructions.Why did you make the changes?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes to the website.