Skip to content

Add github-handle for Tyler Thome in home-unite-us.md #7309

Closed
ihop-56 wants to merge 1 commit intohackforla:gh-pagesfrom
ihop-56:add-tyler-thome-github-handle
Closed

Add github-handle for Tyler Thome in home-unite-us.md #7309
ihop-56 wants to merge 1 commit intohackforla:gh-pagesfrom
ihop-56:add-tyler-thome-github-handle

Conversation

@ihop-56
Copy link
Member

@ihop-56 ihop-56 commented Aug 17, 2024

Fixes #7175

What changes did you make?

  • Added the github-handle: field under name: Tyler Thome in the _projects/home-unite-us.md file. This field was added without a value as per the issue's instructions.

Why did you make the changes?

  • The change was made to prepare the project file for future enhancements, reducing redundancy by standardizing the GitHub handle field.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b ihop-56-add-tyler-thome-github-handle gh-pages
git pull https://github.com/ihop-56/website.git add-tyler-thome-github-handle

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) status: To Update! No update has been provided size: 0.25pt Can be done in 0.5 to 1.5 hours status: Updated No blockers and update is ready for review and removed status: To Update! No update has been provided labels Aug 17, 2024
@iancooperman iancooperman self-requested a review August 17, 2024 17:49
@iancooperman
Copy link
Member

iancooperman commented Aug 17, 2024

Review ETA: EoD

Copy link
Member

@iancooperman iancooperman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This largely looks good, but please add the issue number "7175" to the name of your branch in your fork.

@t-will-gillis t-will-gillis requested a review from 8alpreet August 18, 2024 17:11
@8alpreet
Copy link
Member

8alpreet commented Aug 19, 2024

Review ETA: EOD
Availability: Mon to Fri; 3 p.m. to 7 p.m.

  • Step 0: Is the pull request done with the correct branch?
  • Step 1: Is there a linked issue?
  • Step 2: Understand the linked issue.
  • Step 3: View the changes in the browser.
  • Step 4: Take a look at files changed tab.
  • Step 5: Check for anything else.
  • Step 6: Approve the pull request.
  • Step 7: Clean up your working repo.

Copy link
Member

@8alpreet 8alpreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ihop-56,

What went well:

  • Into branch is set up correctly.
  • PR is linked to the correct issue number.
  • Only relevant lines of code were changed.

Changes needed:

  1. The issue number must be a part of the branch name. It works well as a suffix (in my opinion).
  2. The "what changes did you make" section:
    • It has repeated sentences.
    • It mentions visual changes which has a section of it's own thus does not need to be discussed in this section.
    • It does not provide insight into the changes, rather it points the reader to the issue. Which is not an invalid approach; however, It would be helpful to reiterate the intention of the linked issue in your own words.

Copy link
Member

@minkang3 minkang3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File changes look good.

There is a slight formatting error in your PR where your second bullet point is not spaced properly. Add a space after "-" and it should be fixed.

@codyyjxn
Copy link
Member

Review ETA: 9am - 8pm 8/22/2024
Availability: 5am - 8PM Monday-Friday

Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ihop-56

Things you did correctly:

  1. Branch is set up correctly.
  2. PR is linked to the correct issue number.
  3. Correct file change

Things you should change:

  1. In the "What changes did you make?" section, try to keep it concise and avoid repetition.
  2. Including the issue number in the branch name is a good practice. It helps others quickly identify the context, especially when viewing the branch for the first time.

@ihop-56 ihop-56 changed the title Add github-handle for Tyler Thome in home-unite-us.md Add github-handle for Tyler Thome in home-unite-us.md #7175 Aug 23, 2024
@ihop-56 ihop-56 changed the title Add github-handle for Tyler Thome in home-unite-us.md #7175 Add github-handle for Tyler Thome in home-unite-us.md Aug 23, 2024
@ihop-56 ihop-56 changed the title Add github-handle for Tyler Thome in home-unite-us.md Add github-handle for Tyler Thome in home-unite-us.md #7175 Aug 23, 2024
@ihop-56
Copy link
Member Author

ihop-56 commented Aug 23, 2024

Hi @codyyjxn

I've made the requested changes:

Updated the branch name to include the correct issue number #7175.
Revised the PR description to remove redundancy and clarify the changes made.
Let me know if there's anything else needed.

@codyyjxn
Copy link
Member

codyyjxn commented Aug 23, 2024

Hi @ihop-56,
I apologize for any confusion earlier. What I meant to convey is that the issue number should be included in the branch name : ihop-56:add-tyler-thome-github-handle.

The title was fine before. No need to add the issue number on the title.

@ihop-56 ihop-56 changed the title Add github-handle for Tyler Thome in home-unite-us.md #7175 Add github-handle for Tyler Thome in home-unite-us.md Aug 23, 2024
@ihop-56
Copy link
Member Author

ihop-56 commented Aug 23, 2024

Hi @codyyjxn

I've updated the branch name to add-tyler-thome-github-handle-7175 as requested.

Please let me know if there's anything else needed.

Thank you!

@8alpreet
Copy link
Member

Hi @ihop-56, I looked it up and it's not possible to rename a branch when a PR is open. Technically, branches are not renamed on Github, they are deleted and replaced. I went onto your account and saw that you have created a new branch containing the issue number but it is not linked to this PR. You will have to open a new PR.

Useful instructions for updating branch name: LINK

@bexux
Copy link
Member

bexux commented Aug 25, 2024

Hi @ihop-5 -6 Thank you for updating the branch name. Since you have created a new PR from that new branch, you may want to close this one to avoid confusion. I will link the new one here for reference. #7346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours status: Updated No blockers and update is ready for review

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Tyler Thome in home-unite-us.md

6 participants