Add tyler thome GitHub handle 7175#7346
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 8 PM pacific 8/24/24 |
bexux
left a comment
There was a problem hiding this comment.
This is very close to being done! Looks like you had the code correct on your first commit, but then the second commit, Changes before switching branches added in value that is not needed for this issue.
The PR description reads well, branching done correctly, and issue attached correctly. Just need the small change.
|
Yes, that's right
…On Fri, Aug 23, 2024, 7:08 PM Rebecca ***@***.***> wrote:
@ihop-56 <https://github.com/ihop-56> I noticed you have a second PR -
7309 <#7309> pushed up to
address issue 7175. I assume this PR is in response to @codyyjxn
<https://github.com/codyyjxn>'s feedback to have the issue number in the
branch name?
—
Reply to this email directly, view it on GitHub
<#7346 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BA5P266COG2VWL65OYY4UXLZS66GZAVCNFSM6AAAAABNAZKFPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBXHEYTANJXGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi @bexux, I've made the requested changes:
Please review and let me know if any further adjustments are needed. Thank you for your guidance! |
|
HI @ihop-56 please don't forget to re-request a review by selecting the chasing arrows next to the reviewer's handle when you make changes to address a reviewer's comments: |
8alpreet
left a comment
There was a problem hiding this comment.
Hi @ihop-56,
Thanks for making changes in accordance to feedback on this and the previous PR.
Opinion:
- The PR looks good, but I would encourage you to do one last thing: squash the commits. I'm not sure if this is practice on this project, but merging three commits will pollute the the commit history unnecessarily.
Nitpick:
- Not necessary, but you could capitalize "Tyler Thome" in the PR title.
I am approving, but urge you to squash the commits.
bexux
left a comment
There was a problem hiding this comment.
Looks great! Thank you for making the changes.
Got it, thanks @t-will-gillis! |

Fixes #7175
What changes did you make?
github-handle:field undername: Tyler Thomein the_projects/home-unite-us.mdfile. This field was added without a value as per the issue's instructions.Why did you make the changes?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes to the website.