Removing instances of "test" as a substring in the events page - #6369#7464
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
ETA: 2 hrs |
|
Review ETA: by Thursday (9/19) or Friday (9/20) |
codyyjxn
left a comment
There was a problem hiding this comment.
@dcotelessa Great job on taking on this issue. The changes are clear and the title is also concise on the tings that were changed. I ran the test and everything seemed to work as intended.
vorleakyek
left a comment
There was a problem hiding this comment.
Nice work on adding the vrmsDataFilter function. But, we should update the variable name "vrmsData" to "vrmsDataFilter" in the comment to avoid any confusion later.
|
Wanted to mention this is only |
codyyjxn
left a comment
There was a problem hiding this comment.
@dcotelessa Nice work!
- The function you developed is clear and easy to follow.
- You applied it to the VRMS data accurately.
- Including the before-and-after process effectively highlights the changes made.
- Your thoughtful approach makes it easy for others to understand your work.
vorleakyek
left a comment
There was a problem hiding this comment.
Verified that "Test-EventName" is no longer showing up on the events page on the Hack for LA website. Thanks!
Fixes #6369
What changes did you make?
Why did you make the changes (we will use this info to test)?
/assets/js/utility/vrms-events.js, the code-block rendering events from the VRMS to the website contain "test" eventsScreenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied