Skip to content

Removing instances of "test" as a substring in the events page - #6369 #7464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daras-cu merged 3 commits into from
Sep 24, 2024
Merged

Removing instances of "test" as a substring in the events page - #6369 #7464

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d918570
add vrms events filter "test"
dcotelessa Sep 16, 2024
6bc9480
use regex for test testing search instead
dcotelessa Sep 20, 2024
766b63e
update vrms regex
dcotelessa Sep 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions assets/js/utility/vrms-events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,18 @@
{% assign vrmsData = site.data.external.vrms_data %}
const vrmsData = JSON.parse(decodeURIComponent("{{ vrmsData | jsonify | uri_escape }}"));

/* vrmsDataFetch calls sortByDate function and passes vrmsData variable, current page which can either be "events" for the right-col-content.html page or
/* vrmsDataFilter is a function that filters the vrmsData array to remove the instances of "test" or "testing" from the events page.
We need to add logic for removing any event that contain "test" or "testing" (case-insensitive) from the events page.
*/
const vrmsDataFilter = (vrmsData) => vrmsData.filter(data => data.name.match(/\btest(ing)?\b/i) === null);
const filteredVrmsData = vrmsDataFilter(vrmsData);

/* vrmsDataFetch calls sortByDate function and passes filteredVrmsData variable, current page which can either be "events" for the right-col-content.html page or
"project" from the project.html page, and passes the appendMeetingTimes function from projects.js that appends the sorted vrmsData
returned by sortByDate to project.html. AppendMeetingTimes is only called if vrmsDataFetch is being called from project.js for the project.html page
*/
export const vrmsDataFetch = (currentPage, appendMeetingTimes) => {
return sortByDate(vrmsData, currentPage, appendMeetingTimes)
return sortByDate(filteredVrmsData, currentPage, appendMeetingTimes)
}

// Helper function used for project.html and right-col-content.html to sort VRMS data by day of the week from "date" key and meeting time from "startTime" key
Expand Down