feat: action to rename a module#379
Merged
mergify[bot] merged 2 commits intomainfrom Apr 25, 2022
Merged
Conversation
brprice
commented
Apr 13, 2022
brprice
force-pushed
the
brprice/module-rename
branch
from
11179f7 to
c946e3d
Compare
brprice
force-pushed
the
brprice/module-names
branch
2 times, most recently
from
8aa5dcf to
69b7753
Compare
brprice
force-pushed
the
brprice/module-rename
branch
2 times, most recently
from
dd0a135 to
6938d0d
Compare
brprice
force-pushed
the
brprice/module-names
branch
from
39cf2ca to
496a7ea
Compare
brprice
force-pushed
the
brprice/module-rename
branch
from
76ea118 to
7996963
Compare
georgefst
approved these changes
Apr 20, 2022
brprice
force-pushed
the
brprice/module-names
branch
4 times, most recently
from
83602e5 to
ec61235
Compare
This makes renaming modules a lot slicker, as we can do more generically.
The reason for the slightly convoluted implementation is that I am looking forward to when we have multiple editable modules, where we need to edit multiple modules (as they all may contain references to the renamed module). A potential optimisation is only checking for name clashes with imports and not rewriting theose modules, since we do not support renaming imports, and imports cannot depend on the editable module. I also take the chance to simplify the test code which does module renaming, now that the idea has been properly implemented in the library, with name clash detection. It is not worth making the library more complex or exposing an "unsafe" version for one use in testsuite (which intentionally clashes names, in order to merge modules).
brprice
force-pushed
the
brprice/module-rename
branch
from
e8cdbfc to
6d15e60
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.