merge-queue: embarking main (5f8b303) and #379 together#409
Closed
mergify[bot] wants to merge 3 commits intomainfrom
Closed
merge-queue: embarking main (5f8b303) and #379 together#409mergify[bot] wants to merge 3 commits intomainfrom
mergify[bot] wants to merge 3 commits intomainfrom
Conversation
This makes renaming modules a lot slicker, as we can do more generically.
The reason for the slightly convoluted implementation is that I am looking forward to when we have multiple editable modules, where we need to edit multiple modules (as they all may contain references to the renamed module). A potential optimisation is only checking for name clashes with imports and not rewriting theose modules, since we do not support renaming imports, and imports cannot depend on the editable module. I also take the chance to simplify the test code which does module renaming, now that the idea has been properly implemented in the library, with name clash detection. It is not worth making the library more complex or exposing an "unsafe" version for one use in testsuite (which intentionally clashes names, in order to merge modules).
Author
|
The pull request #379 is mergeable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This combination of pull requests has been checked successfully 🎉
Branch main (5f8b303) and #379 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #379.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
defaultfor merge:base=maincheck-success="buildkite/primer/pr/required"More informations about Mergify merge queue can be found in the documentation.
Mergify commands
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the queue rulesAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com