feat!: hierarchical module names#385
Merged
mergify[bot] merged 1 commit intomainfrom Apr 25, 2022
Merged
Conversation
brprice
changed the base branch from
brprice/module-names
to
brprice/module-rename
brprice
force-pushed
the
brprice/modules-hierarchy
branch
from
c566692 to
8519d2e
Compare
Contributor
Author
|
This first commit just changes the types to allow for the possibility of hierarchical module names, but does not actually take advantage of that fact. (For instance, we may want to split up the primitive module into |
This was referenced Apr 14, 2022
brprice
force-pushed
the
brprice/module-rename
branch
2 times, most recently
from
dd0a135 to
6938d0d
Compare
brprice
force-pushed
the
brprice/modules-hierarchy
branch
from
8519d2e to
9232f8b
Compare
brprice
force-pushed
the
brprice/module-rename
branch
from
76ea118 to
7996963
Compare
brprice
force-pushed
the
brprice/modules-hierarchy
branch
from
9232f8b to
d587bbe
Compare
georgefst
approved these changes
Apr 20, 2022
brprice
force-pushed
the
brprice/module-rename
branch
from
e8cdbfc to
6d15e60
Compare
A `ModuleName` is now a non-empty list, so one can have nested namespaces. BREAKING CHANGE: this change requires a database migration, as it changes the representation of `Prog`. However, since this is just serialised to json and stored as a blob in the DB, it requires no schema changes. Since we have no programs we need to preserve, we decided not to bother with a migration. This means that DBs created before this commit will not load with a primer containing this commit.
brprice
force-pushed
the
brprice/modules-hierarchy
branch
from
d587bbe to
78c6331
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
ModuleNameis now a non-empty list, so one can have nested namespaces.BREAKING CHANGE: this change requires a database migration, as it changes the representation of
Prog. However, since this is just serialised to json and stored as a blob in the DB, it requires no schema changes. Since we have no programs we need to preserve, we decided not to bother with a migration. This means that DBs created before this commit will not load with a primer containing this commit.