Conversation
brprice
commented
Feb 1, 2023
brprice
force-pushed
the
brprice/benchmark-edits
branch
from
335ac70 to
28e524c
Compare
brprice
force-pushed
the
brprice/benchmark-edits
branch
from
28e524c to
b114f19
Compare
brprice
force-pushed
the
brprice/benchmark-tc
branch
from
903c429 to
4e5b3c6
Compare
brprice
force-pushed
the
brprice/benchmark-edits
branch
2 times, most recently
from
96f8b67 to
7ffe906
Compare
brprice
force-pushed
the
brprice/benchmark-tc
branch
from
4e5b3c6 to
c5573ad
Compare
brprice
force-pushed
the
brprice/benchmark-edits
branch
2 times, most recently
from
f60c8f1 to
15829f3
Compare
brprice
commented
Feb 4, 2023
dhess
reviewed
Feb 4, 2023
dhess
reviewed
Feb 4, 2023
dhess
reviewed
Feb 4, 2023
| @@ -0,0 +1,73 @@ | |||
| Edit [RenameDef (GlobalName {qualifiedModule = ModuleName {unModuleName = "Main" :| []}, baseName = "main"}) "sayHello"] | |||
Member
There was a problem hiding this comment.
I can imagine these getting pretty long. I suppose there's some value in leaving the logs as plaintext, because being able to see the diffs when they're updated might occasionally be useful, but I'm inclined to want to compress these before committing them to the repo.
Contributor
Author
There was a problem hiding this comment.
For what reasons in particular? (Note that, iiuc, git internally stores files compressed (in slightly different ways depending on if it is a loose object or part of a pack file), so I'm not sure it will save much space in the repo. (It will save some in a checkout though).
Member
There was a problem hiding this comment.
They might get unwieldy if they grow to a few megabytes. I suppose we can leave them uncompressed for now and see how it goes.
dhess
reviewed
Feb 4, 2023
brprice
force-pushed
the
brprice/benchmark-tc
branch
from
c5573ad to
dce4982
Compare
brprice
force-pushed
the
brprice/benchmark-edits
branch
from
15829f3 to
84e5a17
Compare
brprice
force-pushed
the
brprice/benchmark-edits
branch
2 times, most recently
from
9be5b4c to
7558d8b
Compare
This was referenced Feb 20, 2023
brprice
force-pushed
the
brprice/benchmark-edits
branch
from
191cfa8 to
976c3f5
Compare
dhess
reviewed
Feb 21, 2023
dhess
reviewed
Feb 21, 2023
dhess
reviewed
Feb 21, 2023
dhess
approved these changes
Feb 21, 2023
Member
dhess
left a comment
dhess
left a comment
There was a problem hiding this comment.
Looks good after all the cleanups, thanks!
brprice
force-pushed
the
brprice/benchmark-edits
branch
2 times, most recently
from
fa680aa to
9bf13e3
Compare
This is to enable adding a benchmark of the edit-action handler.
We add these instances as setup for "replay fixtures", where we wish to record a list of actions in a file and replay these as a benchmark. The strategy is simple: we already log API calls, so we can extract actions from primer's log; we simply need to be able to 'Read' them in from a file.
To record fixtures to replay (for debugging or benchmarking), we essentially want detailed logs. Currently our standard logs are verbose enough to enable this, but this will not be true in the future. We decouple these two uses, so (in future work) we can modify what we log by default without breaking the workflow of recording fixtures.
brprice
force-pushed
the
brprice/benchmark-edits
branch
from
9bf13e3 to
f535eac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.