Closed
Conversation
We now emit `RequestStart` log lines, to aid in extracting test/benchmark cases. When looking at the generated logs, note that: - log messages from multiple simultaneous interactions may be interleaved - we log some internal high-level requests, so one API request can generate many log lines. - each group is preceeded by a `RequestStart` line -- this shows where a new request was started, and the following messages will be various stages of handling it. - we will have at most one `Edit` per request, but it will probably be after some `ApplyAction*` and `GetProgram` lines, which correspond to the actual API request made by your frontend and an internal implemetation detail. - technically, there is no guarantee that the `RequestStart` line is actually consecutive with its generated logs, but it is normally the case for a single-user session.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now emit
RequestStartlog lines, to aid in extracting test/benchmark cases.When looking at the generated logs, note that:
RequestStartline -- this shows where a new request was started, and the following messages will be various stages of handling it.Editper request, but it will probably be after someApplyAction*andGetProgramlines, which correspond to the actual API request made by your frontend and an internal implemetation detail.RequestStartline is actually consecutive with its generated logs, but it is normally the case for a single-user session.This was split out of #863, as it no longer makes sense as part of that PR. I am opening this PR mostly to save the code in case anyone thinks it will be useful -- I have no particular desire to merge it at the current time.