Hide inaccessible symbols in internal linkage#5548
Merged
Conversation
steven-johnson
approved these changes
Dec 11, 2020
Member
|
+1 I think we should export all symbols to enable crazy experimentation, but only symbols that have a definition in Halide.h. So things inside c++ files that don't appear in a header should definitely be in an anonymous namespace. |
Contributor
Author
|
Note that I did move some of the GPU codegen classes to the cpp file, so this PR is hiding some symbols from the header. |
Member
|
I noticed that, but those things really should have been internal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to debug an issue on the arm-32 buildbots recently, and linking libHalide.so was taking ages to run. I don't know if this helps, but it seems like a good thing to do regardless. We already do a lot of this, just not consistently.
Related to #4651.