Move CodeGen_Hexagon to internal linkage and don't include it without WITH_HEXAGON#5567
Merged
Move CodeGen_Hexagon to internal linkage and don't include it without WITH_HEXAGON#5567
Conversation
Contributor
|
Is GLSL still needed for OpenGLCompute? |
steven-johnson
approved these changes
Dec 16, 2020
Contributor
Author
|
I meant the vertex buffer stuff, which I imagine wouldn't be needed for OpenGLCompute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an alternative to #5503 to address #5559. This is similar to #5548.
It moves all of
CodeGen_Hexagoninto an internal linkage namespace, and wraps the whole thing in an#ifdef WITH_HEXAGON.I wanted to do this for all of the
CodeGen_*classes, but this only works forCodeGen_Hexagonbecause it isn't used byCodeGen_GPU_Hostas a template parameter.I think we should move the runtime calls generated by
CodeGen_GPU_Hostto a separate lowering pass (like how HexagonOffload does it), and then we could do this for the rest of theCodeGen_*classes as well. I think most of the complexity there is GLSL, which might go away soon (#5475)?