Fix verbose location reporting for internal assertions#8848
Merged
alexreinking merged 1 commit intomainfrom Oct 21, 2025
Merged
Fix verbose location reporting for internal assertions#8848alexreinking merged 1 commit intomainfrom
alexreinking merged 1 commit intomainfrom
Conversation
TH3CHARLie
approved these changes
Oct 21, 2025
Contributor
TH3CHARLie
left a comment
There was a problem hiding this comment.
Thanks! I verified locally and it's the expected behavior again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects the conditions on the printing of source location and condition information. For example, we now see the following when the
error_bad_func_objecttest is run.When manually testing with
user_assert, I can confirm that the extra information is printed whenHL_DEBUG_CODEGENis set to1or higher.Fixes #8847