Skip to content

Fix verbose location reporting for internal assertions#8848

Merged
alexreinking merged 1 commit intomainfrom
bugfix/error-info
Oct 21, 2025
Merged

Fix verbose location reporting for internal assertions#8848
alexreinking merged 1 commit intomainfrom
bugfix/error-info

Conversation

@alexreinking
Copy link
Member

This PR corrects the conditions on the printing of source location and condition information. For example, we now see the following when the error_bad_func_object test is run.

Internal error at /Users/areinking/dev/Halide/src/Func.cpp:88
Condition failed: func.get_contents().defined()
Error: Can't construct Func from undefined Function

When manually testing with user_assert, I can confirm that the extra information is printed when HL_DEBUG_CODEGEN is set to 1 or higher.

Fixes #8847

Copy link
Contributor

@TH3CHARLie TH3CHARLie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I verified locally and it's the expected behavior again

@alexreinking alexreinking merged commit ed156e7 into main Oct 21, 2025
19 checks passed
@alexreinking alexreinking deleted the bugfix/error-info branch October 21, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error reporting behaviour inconsistent with previous Halide

2 participants