Fix CI timeout #1061
Merged
Fix CI timeout #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1061 +/- ##
========================================
Coverage 70.82% 70.82%
========================================
Files 79 79
Lines 7610 7610
========================================
Hits 5390 5390
Misses 2220 2220 |
felixdivo
approved these changes
Jun 2, 2021
Collaborator
felixdivo
left a comment
felixdivo
left a comment
There was a problem hiding this comment.
Good catch. Also fixes Travis CI. However, it found a small pylint issue: https://travis-ci.com/github/hardbyte/python-can/jobs/510144309#L589
Collaborator
|
Merging as it at least gets things to work a bit better. #1068 Should also be merged soon to get all CI green again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constrain dependency versions so the pip resolver can finish in adequate time. Otherwise GHA runs into timeout as seen here