Improve IO module typing #1068
Merged
Improve IO module typing #1068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Collaborator
Author
|
@Mergifyio rebase |
Contributor
|
Command
|
hardbyte
force-pushed
the
fix-linter-issue-simple_log_converter
branch
from
5b01e63 to
ab3c4f4
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1068 +/- ##
===========================================
+ Coverage 70.77% 72.90% +2.12%
===========================================
Files 79 79
Lines 7607 7684 +77
===========================================
+ Hits 5384 5602 +218
+ Misses 2223 2082 -141 |
zariiii9003
reviewed
Jun 5, 2021
Collaborator
Author
|
@zariiii9003 It should work now. |
Collaborator
|
Mypy still does not seem happy: https://travis-ci.com/github/hardbyte/python-can/jobs/511375046#L586 |
Collaborator
Author
|
@zariiii9003 It seems like pylint does not recognize the type annotations that it really is an |
zariiii9003
approved these changes
Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes the mypy issue found in #1061.