caching msg.data value #798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid calling msg.data multiple times by caching msg.data value
felixdivo
approved these changes
Mar 20, 2020
Collaborator
felixdivo
left a comment
felixdivo
left a comment
There was a problem hiding this comment.
This seems to be correct, but I cannot comment on the speedup gained by this.
Codecov Report
@@ Coverage Diff @@
## develop #798 +/- ##
===========================================
- Coverage 69.54% 69.53% -0.02%
===========================================
Files 70 70
Lines 6547 6548 +1
===========================================
Hits 4553 4553
- Misses 1994 1995 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid calling msg.data multiple times by caching msg.data value