Skip to content

Conversation

@certik
Copy link
Member

@certik certik commented May 18, 2015

This is needed, otherwise cmake fails to compile packages.

@certik certik mentioned this pull request May 18, 2015
4 tasks
@ahmadia
Copy link
Contributor

ahmadia commented May 18, 2015

This is certainly "new". This is sometimes needed to make Python packages build correctly, and for enforcing deployment targets.

@certik
Copy link
Member Author

certik commented May 18, 2015

There might be some way to convince CMake to work with MACOSX_DEPLOYMENT_TARGET. I found, as you said, that Python (and perhaps more packages) require MACOSX_DEPLOYMENT_TARGET to be properly set so I set it in PROLOGUE. However, cmake always fails to build other packages, if this is set --- so one solution is to unset MACOSX_DEPLOYMENT_TARGET just for packages build using cmake, the other solution is to figure out how to make cmake work with it (I think that would be preferable, probably). This PR implements the former.

@johannesring
Copy link
Contributor

See also issue #368.

@certik
Copy link
Member Author

certik commented Dec 22, 2015

See also #902. It looks like on El Capitan at least, things are working as expected.

@certik certik closed this Dec 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants